-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove netstandard1.x dependencies #5191
base: main
Are you sure you want to change the base?
Changes from all commits
25e1532
7ecc00d
c51a8fb
bc2ac14
d109194
be8fbb9
4f85622
7bbe8f5
7dae030
29165d5
8a64213
ed0c007
1dc2308
d322207
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -40,12 +40,8 @@ | |||||||||||||||||||||||||||||||
<ProjectReference Include="$(RepoRoot)src\Microsoft.TestPlatform.CoreUtilities\Microsoft.TestPlatform.CoreUtilities.csproj" /> | ||||||||||||||||||||||||||||||||
</ItemGroup> | ||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' "> | ||||||||||||||||||||||||||||||||
<PackageReference Include="System.Security.Principal.Windows" Version="4.0.0" /> | ||||||||||||||||||||||||||||||||
</ItemGroup> | ||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' "> | ||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not seeing how this condition would ever be true given There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On anything newer than .NET 5, this package shouldn't be referenced anymore as the library got moved inbox.
This logic adds the latest and previous .NETCoreApp TFMs to all projects: vstest/Directory.Build.targets Lines 10 to 24 in ffe9e9a
|
||||||||||||||||||||||||||||||||
<PackageReference Include="System.Security.Principal.Windows" Version="5.0.0" /> | ||||||||||||||||||||||||||||||||
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | ||||||||||||||||||||||||||||||||
<PackageReference Include="System.Security.Principal.Windows" Version="$(SystemSecurityPrincipalWindowsVersion)" /> | ||||||||||||||||||||||||||||||||
</ItemGroup> | ||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
<ItemGroup> | ||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is very old. Dropping it in order to pick up System.Diagnostics.FileVersionInfo.dll via the implicit netcore app ref.