No need for memento hack #234450
Merged
No need for memento hack #234450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSAL node made `clearCache` synchronous 🎉 so we can safely depend on it for clearing the cache. > Context: The default behavior of MSAL's internal cache is that it is a union with what's in the persistant cache (secret storage) but what _we_ want is that secret storage is the source of truth, so every time we receive an update to secret storage, we clear the in-memory cache to get the data from the persistant cache. Also bumps msal-node-extensions while we're at it.
TylerLeonhardt
added a commit
that referenced
this pull request
Nov 22, 2024
We needed this workaround because MSAL was always trying to require a native module we never use. I sent a PR to MSAL to rework their behavior and that has now been released and we pulled that in in #234450 With the updated msal-node-extensions library, we no longer need to do this webpack logic.
TylerLeonhardt
added a commit
that referenced
this pull request
Nov 22, 2024
We needed this workaround because MSAL was always trying to require a native module we never use. I sent a PR to MSAL to rework their behavior and that has now been released and we pulled that in in #234450 With the updated msal-node-extensions library, we no longer need to do this webpack logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSAL node made
clearCachesynchronous 🎉 so we can safely depend on it for clearing the cache.Also bumps msal-node-extensions while we're at it.