Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @vscode/windows-registry to 1.0.5 in remote #140599

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

ChaseKnowlden
Copy link
Contributor

@ChaseKnowlden ChaseKnowlden commented Jan 12, 2022

Removed old references to vscode-windows-registry.

This PR fixes #140564

@ChaseKnowlden ChaseKnowlden changed the title 🆙 @vscode/[email protected] Bump @vscode/windows-registry to 1.0.5 Jan 12, 2022
@ChaseKnowlden ChaseKnowlden changed the title Bump @vscode/windows-registry to 1.0.5 Bump @vscode/windows-registry to 1.0.5 in remote Jan 12, 2022
@@ -14,8 +14,8 @@
"https-proxy-agent": "^2.2.3",
"iconv-lite-umd": "0.6.10",
"jschardet": "3.0.0",
"minimist": "^1.2.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although I understand why this is moved, please don't include this change, thanks for the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved it back to how it was originally.

@Tyriar
Copy link
Member

Tyriar commented Jan 13, 2022

@sbatten FYI you may want to alias like ripgrep: #140585, I think we should do this for all modules and announce the change in release notes to give extensions time to react.

@sbatten sbatten merged commit 8705e6a into microsoft:main Jan 21, 2022
@ChaseKnowlden ChaseKnowlden deleted the issue-140564 branch January 21, 2022 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vscode/windows-registry is not properly adopted
3 participants