Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Multiple GitHub Account support & new auth account preference #231880

Closed
2 tasks done
TylerLeonhardt opened this issue Oct 21, 2024 · 1 comment
Closed
2 tasks done

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Oct 21, 2024

Refs: #127967 #225943 #229421

Complexity: 4

Create Issue


Description

Last iteration we did this for just Insiders, now..... We have enabled Multiple GitHub Account support for everyone. This means you can be logged in to 2+ accounts at the same time and use them for different things.

I really just want you to smoke test logging in to multiple things and seeing if it all makes sense.

Step 0: Get an alt GitHub account

There's really only one way to do this... you gotta get/make another GitHub account. It's kinda annoying, but it could be useful later!

I guess you could also try to get the EMU account working... the one that's like YourMicrosoftAlias_microsoft (so like tyleonha_microsoft). That'd be a good test if you can figure out how to use it.

Step 1: Grab some extensions

So first, let me list some extensions that use GitHub:

  • Settings Sync
  • Cloud Changes
  • Remote Tunnels
  • GitHub Pull Request
  • GitHub Copilot & Chat
  • GitHub Repositories
  • GitHub Codespaces
  • GitLens
  • Live Share
  • And More?!....

Step 2: Change the preference

Also, to light this up, we have also added an ability to change the account preference for an extension. So for example, if Copilot Chat was originally given AccountA, a user can go in and change the preference to AccountB, and Copilot Chat will get an event for this change.

Now just a quick overview of where you could switch accounts... either:

  • Account Menu -> An Account -> Manage Trusted Extensions -> Gear icon on one of the Extensions
  • Extensions View -> Right click OR Gear icon on an extension
  • An Extension Editor -> Gear icon towards the top

This should bring you to a Quick Pick that lets you set a default account (you may not have one initially, but after setting it, re-open the quick pick and it should say it's default)

It's possible that not every extension plays nice with this new behavior... not all of them implement the Authentication event properly... so if you feel like an extension isn't handling it properly, I'd love it if you could open an issue on the extension... but if you don't want to, open an issue here and I'll get to it.

Step 2.1: Use the Use new account... option in the account preference quick pick

As a part of this, PLEASE try out the new option in the "switch accounts" QuickPick: "Use new account..."

Image

Bonus

GitHub Copilot Chat and GitHub Copilot's preference has been locked... so when you update one, the other updates. Test that! It'll test better if you switch between an account that has a Copilot Sub and one that doesn't...

@TylerLeonhardt TylerLeonhardt added this to the October 2024 milestone Oct 21, 2024
@bamurtaugh bamurtaugh self-assigned this Oct 22, 2024
@rzhao271 rzhao271 self-assigned this Oct 22, 2024
@rzhao271
Copy link
Contributor

rzhao271 commented Oct 22, 2024

I'm unable to test the Copilot extensions on web.
GHPRI, Issues Notebook, and Remote Tunnels along with the new quick pick LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants