Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nothing happens when I select Account Preferences on certain extensions #231966

Closed
bamurtaugh opened this issue Oct 22, 2024 · 3 comments · Fixed by #232068
Closed

Nothing happens when I select Account Preferences on certain extensions #231966

bamurtaugh opened this issue Oct 22, 2024 · 3 comments · Fixed by #232068
Assignees
@TylerLeonhardt
Labels
authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
October 2024

Comments

@bamurtaugh
Copy link
Member

bamurtaugh commented Oct 22, 2024 •
edited
Loading

Testing #229420, #231880

Version: 1.95.0-insider (user setup)
Commit: 804f450ca900d24db25e7174e8b6dfb3fb2a318c
Date: 2024-10-22T13:30:10.100Z
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.26120

GH Copilot: v1.241.1169 (pre-release)
GH Copilot Chat: v0.22.2024102202 (pre-release)
OS: Windows 11 Insiders

Image
@bamurtaugh
Copy link
Member Author

bamurtaugh commented Oct 22, 2024 •
edited
Loading

I experience the same issue with GitHub Repositories, GitHub Codespaces, and Live Share.

@bamurtaugh bamurtaugh changed the title Nothing happens when I select Account Preferences on Remote - Tunnels Nothing happens when I select Account Preferences on certain extensions Oct 22, 2024
@bamurtaugh
Copy link
Member Author

bamurtaugh commented Oct 22, 2024 •
edited
Loading

I can get into the account preference menu if I go via: Account Menu -> An Account -> Manage Trusted Extensions -> Gear icon on one of the Extensions.

Example for Live Share through this path:

Image
Image

But if I go through the other paths, nothing happens when I click Account Preferences:

Image

@TylerLeonhardt
Copy link
Member

The root cause is that Remote Tunnels is "trusted for BOTH GitHub & Microsoft" (for reasons) this means that:

  • It's an extension that we know can have Account Preferences so we show the item in the Context Menu
  • We don't know which provider to update the preference for because it has access to both GitHub & Microsoft

We could show a quick pick to ask the user which provider (GH/MS) to configure... but at this point in time, it hasn't used any account. And for the Remote Tunnels case, it can ask for both of those types of auth but it really only uses one.

Because this is a bit of a corner case, I will make a more pragmatic change here.

Basically showing a dialog that says "This extension has not used any accounts yet." when you pick the Context Menu Item.

I won't change the experience in the Account Menu... because there we know which auth provider we are changing.

This is all very niche so I think this difference isn't so bad... and once the extension actually uses auth this alllll doesn't matter anymore.

TylerLeonhardt added a commit that referenced this issue Oct 23, 2024
@TylerLeonhardt
Show a modal when an extension has not yet used an account
463e3c6 
Fixes #231966
@TylerLeonhardt TylerLeonhardt mentioned this issue Oct 23, 2024
Merged
TylerLeonhardt added a commit that referenced this issue Oct 23, 2024
@TylerLeonhardt
Show a modal when an extension has not yet used an account (#232068)
f5b8542 
Fixes #231966
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Oct 23, 2024
@vs-code-engineering vs-code-engineering bot added this to the October 2024 milestone Oct 23, 2024
@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug authentication Issues with the Authentication platform labels Oct 23, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 24, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 24, 2024
jmcphers pushed a commit to posit-dev/positron that referenced this issue Nov 13, 2024
@positron-bot @jmcphers
Merge 1.95.0 from upstream
67c53a3 
commit 5dc50ad45fe42b3b3d74cabdadf0aa61e706473e
Author: Jonathan McPherson <[email protected]>
Date:   Wed Nov 6 11:32:44 2024 -0800

    update content hash

commit 805ba7093df1b37fea50eb4225f2440f059bbddd
Author: Jonathan McPherson <[email protected]>
Date:   Wed Nov 6 11:27:03 2024 -0800

    update import from agent server

commit 9f3d0de9a6049b388cff5538b1d43846dfc7dc00
Merge: 85e6d39d5b2 912bb683695
Author: Jonathan McPherson <[email protected]>
Date:   Mon Nov 4 17:17:58 2024 -0800

    Merge tag '1.95.0' into merge/1.95.0

commit 912bb683695358a54ae0c670461738984cbb5b95
Author: Bhavya U <[email protected]>
Date:   Mon Oct 28 09:08:10 2024 -0700

    fix: Dont show chat panel on ext updates (#232328)

commit d7c7d5bd66efeaebded9fada08500da3816d80cf
Author: Benjamin Christopher Simmonds <[email protected]>
Date:   Mon Oct 28 14:58:44 2024 +0100

    Use async find provider for file scheme only (#232373)

    Use async find provider only for file scheme (#230592)

    * only use asyncfindprovider for file scheme

    * add vscode remote

commit 3cb9832e5211e3495400d17d189448a2ce545ed6
Author: Robo <[email protected]>
Date:   Mon Oct 28 22:30:15 2024 +0900

    fix: deb package dependency of libgdk-pixbuf (#232403)

commit 38dc6ac5a771cc94bde1344722bb2d02c80096ea
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 25 14:55:39 2024 -0700

    Remove backcompat workaround (#232302)

    From https://github.com/microsoft/vscode/pull/232023
    Fix #232301

commit 82b2f613fb0f8fe1bba27e0b1e930c018fcc57d2
Author: Joyce Er <[email protected]>
Date:   Fri Oct 25 14:52:42 2024 -0700

    fix: assign better keybinding for edits view on Linux (#232271)

commit dafd758a145285cfb05d7b07c2e6d9461e0efd9e
Author: SteVen Batten <[email protected]>
Date:   Fri Oct 25 14:26:40 2024 -0700

    Don't register view container if we know it will be hidden (#232309)

    just skip the registration if we have state to hide
    keep keybinding

commit ffe7f57b942f6651eaa8a1185a271864e13678fc
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 25 14:17:01 2024 -0700

    Remove 'unknown' from LanguageModelToolResult#constructor (#232284)

    It should be on the content property but no need to be in the constructor.

commit 66b1d83c8158844b4553ca126b3a5f69abf9ba37
Author: Bhavya U <[email protected]>
Date:   Fri Oct 25 14:13:31 2024 -0700

    fix: Show walkthrough if the extension pack has only 1 walkthrough. (#232285)

    * fix: Show walkthrough if the extension pack has only 1 walkthrough

    * fix: Show walkthrough if the extension pack has only 1 walkthrough

    * Fix missing entitlement

commit bf49b09bcb108666bcad06e6d3ddb57de2d4060f
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 25 14:04:17 2024 -0700

    Ensure element is not rendered to 0px when updating height async (#232281)

    This can happen because templateParts are now not disposed when an element is unregistered, but we have to keep their listeners around because they are reused on the next render. A more complete non-candidate fix might be to check whether the element is in the DOM before rendering it at all. But the safe fix here is to just make sure it doesn't go to 0, so that the list doesn't skip rendering it entirely.
    Fix microsoft/vscode-copilot#9260

commit ac6f204b030f2a8aa773fc91032e8d3048d19878
Author: Bhavya U <[email protected]>
Date:   Fri Oct 25 13:59:14 2024 -0700

    fix: chat panel reopen on workspace trust change (#232280)

    fix:chat panel reopen on workspace trust change

commit 24377085e10280d8707b453fdad2c4ee6052fe57
Author: Connor Peet <[email protected]>
Date:   Fri Oct 25 13:45:42 2024 -0700

    debug: update js-debug 1.95.1 for WASM fix (#232289)

    Contains: https://github.com/microsoft/vscode-js-debug/compare/v1.95.0...v1.95.1

commit 360bf09ae640d0faff2972106bfafa0dee7364bf
Author: Johannes Rieken <[email protected]>
Date:   Fri Oct 25 17:55:13 2024 +0200

    Change tool paramters to input and make sure parameters stills works to keep backwards compatibility (#232248)

    fixes https://github.com/microsoft/vscode/issues/232143

commit c0f27916ad81d8de78b62bd0aa0eab3f8cd99178
Author: Benjamin Pasero <[email protected]>
Date:   Fri Oct 25 10:56:14 2024 +0200

    show the command center chat icon in the text (#232210) (#232233)

    Co-authored-by: SteVen Batten <[email protected]>

commit 957cb9444bdb63d6dcbc5180d649901314cefea3
Author: Joyce Er <[email protected]>
Date:   Fri Oct 25 01:49:40 2024 -0700

    fix: assign keybinding for edits view (#232214) (#232215)

    * fix: assign keybinding for edits view (#232214)

    * fix: don't unnecessarily prompt when clearing existing editing session

    * fix: only reveal chat edited files after they exist on disk

    * fix: sync all attachments to working set when submitting request

commit 59260b311c71846b730992d76c6358b43646eea8
Author: Joyce Er <[email protected]>
Date:   Thu Oct 24 16:08:17 2024 -0700

    fix: automatically undo and show retry action for failed editing requests (#232201)

    fix: automatically undo and show retry action for failed requests

commit 5adea6472295b3c9e660f7a6c92676998887cc02
Author: Rob Lourens <[email protected]>
Date:   Thu Oct 24 15:36:46 2024 -0700

    Fix /explain sort order (#232203)

    Fix microsoft/vscode-copilot-release#1923

commit 56c9d0a6b878f48c8afa6271147cc378ad36abbd
Author: Elias Papavasileiou <[email protected]>
Date:   Fri Oct 25 00:23:03 2024 +0300

    fix: improve settings descriptions for actions triggered on save (#230052)

    * fix: improve settings descriptions for actions trigged on save

    * fix: improve phrasing in settings descriptions

    * fix: replace docs link with setting link

    * fix: extract option reference to parameter

commit 2016c3db6366890752c6cc5c2131456c67bc60b5
Author: Michael Lively <[email protected]>
Date:   Thu Oct 24 14:07:21 2024 -0700

    Fix accessible view regression (#232198)

    * accessible view fix

    * don't create wh, check schema for accessibleview

commit 72a2c7c010b6228ef880fa7168e8da6426f3724e
Author: Matt Bierner <[email protected]>
Date:   Thu Oct 24 14:01:46 2024 -0700

    Workaround references list not updating (#232176)

    Not the ideal fix but this makes it so that `ChatCollapsibleListContentPart` does not have a live version of the references list passed to it. The current code results in the item never being re-rendered because `hasSameContent` would always return true, so the references list would not update

    There are a bunch of layers above this that all say they are readonly arrays too. Being readonly is correct from the consumer side, but it looks like the array does get mutated behind the scenes which is often unexpected

commit 2c1d208c7a5afc59ab9cd2b8e73eb53f7db0f937
Author: Connor Peet <[email protected]>
Date:   Thu Oct 24 13:59:55 2024 -0700

    testing: add test result state to context on test explorer items (#232187)

commit 25ab7b28c7be6d28d709e896e1552646e8925941
Author: Joyce Er <[email protected]>
Date:   Thu Oct 24 13:51:18 2024 -0700

    fix: delete files created by chat editing that were subsequently reverted (#232196)

commit 1c39d75f06c0957740d3abea7fe8a1bd5b36666b
Author: Joyce Er <[email protected]>
Date:   Thu Oct 24 13:43:15 2024 -0700

    fix: don't require untitled chat edited files to be part of the workspace (#232172)

commit f338f3d661d32cdb922e11f356c6d06c3d541dd2
Author: SteVen Batten <[email protected]>
Date:   Thu Oct 24 13:07:15 2024 -0700

    update wording based on feedback (#232189)

    * update wording

    * remove test code

    * remove bad comma

    * address PR feedback

commit fa0bf8d285247a66ab176ccb8467416002387a4e
Author: Bhavya U <[email protected]>
Date:   Thu Oct 24 13:05:13 2024 -0700

    feat: add ChatGettingStartedContribution to handle extension installation events (#232191)

commit 964dee35c4efc130989e2f3b11ecf9e54460b6f4
Author: Benjamin Pasero <[email protected]>
Date:   Thu Oct 24 21:52:59 2024 +0200

    Cannot hide mic btn (fix #232042) (#232193)

commit bdc347ebed8f1049f8c316ab2866f05a6a1fb839
Author: Tyler James Leonhardt <[email protected]>
Date:   Thu Oct 24 11:55:02 2024 -0700

    Use ExtensionIdentitfier class to squash some "toLower" bugs (#232179)

    Fixes https://github.com/microsoft/vscode/issues/231964

commit 329740df20b06fd7a1092f2bd1053e5f4388ab11
Author: Benjamin Pasero <[email protected]>
Date:   Thu Oct 24 20:48:47 2024 +0200

    fix: remove experimental tag from chat command center configuration (#232010)

commit 511199a14aaf02a923862be8e00b11a9679621b7
Author: Rob Lourens <[email protected]>
Date:   Thu Oct 24 11:34:46 2024 -0700

    Put implicit context back in quick chat (#232181)

    Fix microsoft/vscode-copilot-release#1985

commit ebd1bd730d919265ee172a7d2d4a73f53cced345
Author: Rob Lourens <[email protected]>
Date:   Thu Oct 24 11:30:54 2024 -0700

    Don't resolve variables a second time after intent detection (#232180)

    Fix microsoft/vscode-copilot#9700

commit c228ff942d0862a699a978c534e2079944b8bb10
Author: SteVen Batten <[email protected]>
Date:   Thu Oct 24 10:52:26 2024 -0700

    moving open chat view command to view so that it applies when the view is moved out of the container (same as search) (#232175)

commit 372134db37a40db8e395ced90915880b8a97f5f2
Author: SteVen Batten <[email protected]>
Date:   Thu Oct 24 10:35:51 2024 -0700

    Hide welcome view if chat view was moved independent of view container (#232173)

    * don't show the welcome view if the chat view has not been moved

    * reorder for clarity

commit 72bc3f95dbf9b5084253564f24985ed2066763fd
Author: Joyce Er <[email protected]>
Date:   Thu Oct 24 10:13:53 2024 -0700

    fix: allow adding untitled editors to chat editing working set (#232170)

commit d80bb0d951f5027ebd2602b3169d602ba733d1de
Author: Bhavya U <[email protected]>
Date:   Thu Oct 24 10:12:12 2024 -0700

    fix: save walkthroughPageTitle in GettingStartedInput (#232169)

commit 5f014654e68fe9e2746e6c9d78b3c86ed14bd56d
Author: Rob Lourens <[email protected]>
Date:   Thu Oct 24 10:09:37 2024 -0700

    Fix quick chat layout (#232167)

    Fix #232096

commit a030b0cd0b81acb028d2bca640d085e5f0e3ad8d
Author: Joyce Er <[email protected]>
Date:   Thu Oct 24 09:51:39 2024 -0700

    fix: add default keybindings for chat editing widget actions (#232162)

commit bf742dbef5725c8a5098fb0295f4996b47d03c4c
Author: Joyce Er <[email protected]>
Date:   Thu Oct 24 09:30:50 2024 -0700

    fix: don't require attachments to enable Send to Edits (#232158)

commit 035dc5ace5ce6d7479454824703cee1559dd41e1
Author: SteVen Batten <[email protected]>
Date:   Thu Oct 24 09:26:41 2024 -0700

    fixes issue where dismissing the view in one window doesn't apply in all windows (#232157)

commit a77b2c285dc21746144e6b88b55ef0511582e4cb
Merge: 568e6a0a515 0c89e7c53f1
Author: Martin Aeschlimann <[email protected]>
Date:   Thu Oct 24 18:26:25 2024 +0200

    Merge pull request #232140 from microsoft/joh/residential-ermine

    let review cancel the session when no or no real edits happened

commit 568e6a0a515a6fa4e6574e7f75aef52827a16978
Author: Peng Lyu <[email protected]>
Date:   Thu Oct 24 09:11:18 2024 -0700

    Enable cell generate fully (#232150)

    * Enable cell generate fully

    * remove experimental tag

commit d53129fbd3c329903b6f82a32f5bd349989c1523
Author: Johannes Rieken <[email protected]>
Date:   Thu Oct 24 17:56:20 2024 +0200

    fix https://github.com/microsoft/vscode-copilot/issues/8327 (#232155)

commit 8d37bf21822f16b5010e6f13dbd46e48c4b5d8ee
Author: Asem Dreibati <[email protected]>
Date:   Thu Oct 24 18:45:06 2024 +0300

    handle edge case in slice function in Iterable namespace (#230683) (#232134)

commit a5931652fe7cc0ea13cdb31859297f75ca961594
Merge: 4c22312702c 07d341613d8
Author: Johannes Rieken <[email protected]>
Date:   Thu Oct 24 17:41:31 2024 +0200

    Merge pull request #232153 from microsoft/joh/experimental-ferret

    various fixes

commit 0c89e7c53f1d059c9828b86afc468d860a392252
Author: Johannes <[email protected]>
Date:   Thu Oct 24 17:28:25 2024 +0200

    more tweaks

commit 07d341613d8093c053ffc51dfc3efbe673614264
Author: Johannes <[email protected]>
Date:   Thu Oct 24 17:20:29 2024 +0200

    use editorOptions from list event

    fixes https://github.com/microsoft/vscode-copilot/issues/9178

commit e07da38a665bdd5072994c61932d342bdd2f292a
Author: Johannes <[email protected]>
Date:   Thu Oct 24 17:15:17 2024 +0200

    tweak padding for attachments

    fixes https://github.com/microsoft/vscode-copilot/issues/9733

commit 308b9dcd6e982a5198bc81aec01fcb4c7f493d9c
Author: Johannes <[email protected]>
Date:   Thu Oct 24 17:09:43 2024 +0200

    capture and restore partial view state

    fixes https://github.com/microsoft/vscode-copilot/issues/9617

commit eaf315a0bc294f63909fd972e3b2084c93e62fdf
Author: Johannes <[email protected]>
Date:   Thu Oct 24 17:09:03 2024 +0200

    tweak padding for toolbar

    fixes https://github.com/microsoft/vscode-copilot/issues/9563

commit 4c22312702ce5b1d701ea3354e7a2e8f6f0416ad
Author: Joyce Er <[email protected]>
Date:   Thu Oct 24 08:00:45 2024 -0700

    fix: allow cancel in New Edit Session (#232148)

commit ffe710dc78580f03d042e404f807a71083f55305
Author: Johannes Rieken <[email protected]>
Date:   Thu Oct 24 16:22:33 2024 +0200

    fixes https://github.com/microsoft/vscode-copilot/issues/9695 (#232135)

commit 26f713df59cc4b8348e0902e2d308ed37a06e13e
Author: Johannes <[email protected]>
Date:   Thu Oct 24 15:25:43 2024 +0200

    let review cancel the session when no or no real edits happened

    https://github.com/microsoft/vscode-copilot-release/issues/1872

commit 1a85a0881e19b4238f9bc01e3268b32c0c1264d1
Author: Ulugbek Abdullaev <[email protected]>
Date:   Thu Oct 24 13:51:48 2024 +0200

    fix a typo (#232132)

commit 4e7b53c5a07914c37ccba0d1211d43d7bc82f420
Author: Robo <[email protected]>
Date:   Thu Oct 24 19:39:28 2024 +0900

    chore: disable mime db creation in snap (#232129)

commit e1de28e4eeaf685668c21bac9b2a0f3a68608c44
Author: SteVen Batten <[email protected]>
Date:   Thu Oct 24 03:26:21 2024 -0700

    move the default location of the chat view (#232098)

commit d450518c924d3212c762e512ba16b9ad20b80a80
Author: Sandeep Somavarapu <[email protected]>
Date:   Thu Oct 24 11:35:37 2024 +0200

    fix #232123 (#232124)

commit 39fd376a04ae461e1abb4212d6395d7a56959198
Author: Joyce Er <[email protected]>
Date:   Wed Oct 23 19:38:16 2024 -0700

    fix: shorten Remove Request action title (#232109)

commit 65b48a02e2563969780642d114773ceb6d5fdaad
Author: Joyce Er <[email protected]>
Date:   Wed Oct 23 18:47:07 2024 -0700

    fix: add preview indicator for editing welcome view (#232108)

commit 7c9e4bb23992c63f20cd86bbe7a52a3aa4bed89d
Author: Joyce Er <[email protected]>
Date:   Wed Oct 23 18:08:14 2024 -0700

    fix: render code blocks with no associated URI in chat editing view (#232105)

commit a4497359d7fc054e7e2f56ce22a40e0d766fd18e
Merge: b3391fd8d98 fc862cb9300
Author: Andrea Mah <[email protected]>
Date:   Wed Oct 23 18:06:57 2024 -0700

    Merge pull request #232106 from microsoft/high-crane

    fix singular AI result with infinite load

commit fc862cb930006e2acaa9193e3d2b9df88488f02b
Author: andreamah <[email protected]>
Date:   Wed Oct 23 17:50:27 2024 -0700

    fix singular AI result with infinite load

commit b3391fd8d989c9300227b0368dd3792eedfac730
Author: Rob Lourens <[email protected]>
Date:   Wed Oct 23 17:06:55 2024 -0700

    Avoid issue where last list item rerenders to get shorter after the request finishes (#232102)

commit c42b584d9551fe176570aa61a02b8497b06f2434
Author: Joyce Er <[email protected]>
Date:   Wed Oct 23 16:32:52 2024 -0700

    fix: make chat editing widget toolbar more compact (#232101)

commit 86a4d1d7b3530d207d43667230ff61b63c44cb64
Author: Johannes Rieken <[email protected]>
Date:   Thu Oct 24 01:25:27 2024 +0200

    tools API tweaks (#232023)

    * update ctor order of `LanguageModelToolCallPart`

    fixes https://github.com/microsoft/vscode/issues/231925

    * :lipstick: make `LanguageModelToolResultPart` follow after `LanguageModelToolCallPart`

    * use `never` for `ChatParticipantToolToken` so that nothing can be assigned to it

    https://github.com/microsoft/vscode/issues/231937

    * polish doc

    * keep API runtime stable

    https://github.com/microsoft/vscode/issues/231938

    * More updates

    * Fix build

    * Add validation for toolInvocationToken

    ---------

    Co-authored-by: Rob Lourens <[email protected]>

commit f67ffbd6da67162016d0bd5cea2d0c91cc2d29e5
Author: Joyce Er <[email protected]>
Date:   Wed Oct 23 16:14:52 2024 -0700

    fix: limit the number of files that can be edited in a chat editing session (#232082)

commit 3126f371b50a0bc36f27c37d4b1cef4d3e52e7d5
Author: Rob Lourens <[email protected]>
Date:   Wed Oct 23 16:09:48 2024 -0700

    Fix scroll issue in edit view (#232100)

commit 55cf6af9582aa88f0a3c99e30904353291238d9c
Author: Tyler James Leonhardt <[email protected]>
Date:   Wed Oct 23 15:59:30 2024 -0700

    Include the auth provider name in the quick pick (#232099)

    Fixes https://github.com/microsoft/vscode/issues/231962

commit 9e5c728530ec7088a02c9778b1b424fa61253b93
Author: Rob Lourens <[email protected]>
Date:   Wed Oct 23 15:05:33 2024 -0700

    Use selected model in 'rerun' inline (#232097)

    Fix microsoft/vscode-copilot#9618

commit f50c72f404249e3c7ec4ed8f0122e03b7dd65bd5
Author: Rob Lourens <[email protected]>
Date:   Wed Oct 23 14:46:06 2024 -0700

    Don't throw when adding an implementation to agents with a disabled when clause (#232094)

    Fix microsoft/vscode-copilot#9658

commit aafaa182180d76bbf0d1e1cd68afa65ec6f407ea
Author: Rob Lourens <[email protected]>
Date:   Wed Oct 23 13:21:07 2024 -0700

    Fix unrevived uris in ignored files API (#232081)

    Fix microsoft/vscode-copilot#9622

commit 45a9f8902795ca9a10f411db90f690f67843d88d
Author: Rob Lourens <[email protected]>
Date:   Wed Oct 23 11:48:38 2024 -0700

    Restore cmd+enter keybinding for "send to @workspace" (#232078)

commit e1e29b63e245d9564f6acaafa53645ca4ca62f96
Merge: f7b57c82422 f83b51466a5
Author: David Dossett <[email protected]>
Date:   Wed Oct 23 10:56:31 2024 -0700

    Merge pull request #232076 from microsoft/ddossett/electronic-pigeon

    Polish edit view styles

commit f83b51466a57563bdc7d56c74086ae79a31744f3
Author: David Dossett <[email protected]>
Date:   Wed Oct 23 10:41:09 2024 -0700

    Polish edit view styles

commit f7b57c824227333f1d6bb80fd21a247b7aef4daa
Author: Connor Peet <[email protected]>
Date:   Wed Oct 23 10:40:22 2024 -0700

    debug: bump js-debug to 1.95 (#232069)

commit a6e5dc321d39c46c94c8aba01d4201f9ea187814
Author: Joyce Er <[email protected]>
Date:   Wed Oct 23 10:33:20 2024 -0700

    fix: reduce padding in chat editing sessions (#232074)

commit f5b85429639e2ade384f0a77e439cce05898c5c6
Author: Tyler James Leonhardt <[email protected]>
Date:   Wed Oct 23 09:14:35 2024 -0700

    Show a modal when an extension has not yet used an account (#232068)

    Fixes https://github.com/microsoft/vscode/issues/231966

commit 7994940ba718f6349a28e26d80a339a19685ecd4
Author: Joyce Er <[email protected]>
Date:   Wed Oct 23 08:11:33 2024 -0700

    fix: simplify undo/redo edit names (#232061)

commit fd6f63ec1ba891e14437d3ce572809c8fa7ae7f9
Author: Joyce Er <[email protected]>
Date:   Wed Oct 23 08:06:13 2024 -0700

    fix: don't render an E on a modified file (#232059)

commit 2f6eb7feaade45236429fff46e6ad5f8b760175e
Author: SteVen Batten <[email protected]>
Date:   Wed Oct 23 07:50:05 2024 -0700

    tweaks the wording of experimental and preview labels (#231991)

    * tweaks the wording of experimental and preview labels

    * one more tweak

commit 1befa2746a541a886f8ae1b79c2fc888605ef4d4
Author: Henning Dieterichs <[email protected]>
Date:   Wed Oct 23 16:45:54 2024 +0200

    Always show inline edit indicator for inline diffs (#232056)

commit 52f35de63b190f232256723170274907865f559c
Author: Henning Dieterichs <[email protected]>
Date:   Wed Oct 23 16:45:11 2024 +0200

    Uses proper theme colors for the inline edit indicator (#232055)

commit 699fdf6d2e377e5ce77b7c01771bdfc1d4aa4320
Author: Johannes Rieken <[email protected]>
Date:   Wed Oct 23 16:43:55 2024 +0200

    reveal first change if possible (#232054)

    fixes https://github.com/microsoft/vscode-copilot/issues/9524

commit 61ba31d9af8d633bfdbede3286c30922feb0bfc3
Author: Henning Dieterichs <[email protected]>
Date:   Wed Oct 23 16:22:05 2024 +0200

    Fixes https://github.com/microsoft/vscode-copilot/issues/9311 (#232052)

commit 1f98cfc4aeca21faef490696a4e09b0340fb126f
Author: Johannes Rieken <[email protected]>
Date:   Wed Oct 23 16:17:43 2024 +0200

    fix https://github.com/microsoft/vscode-copilot/issues/7136 (#232051)

commit 53cc019ca1e7d3a23cd3930c76e16bbecd357d0c
Author: Benjamin Christopher Simmonds <[email protected]>
Date:   Wed Oct 23 16:02:05 2024 +0200

    Add metadata to commands and fix remove view command (#232048)

    add meta data to commands and fix remove view command

commit 4a06986548a5b60e06aff7fa0dc6e2fd9bce0223
Author: Joyce Er <[email protected]>
Date:   Wed Oct 23 06:37:21 2024 -0700

    Fix #232028 (#232046)

commit 1097df99c799f0de0e11b443d508d657054378e7
Author: Johannes Rieken <[email protected]>
Date:   Wed Oct 23 15:34:11 2024 +0200

    remove unused and falsly flagged setting (#232044)

commit 1d3c7c09ad09a5de244005962f11409694f3940c
Author: Sandeep Somavarapu <[email protected]>
Date:   Wed Oct 23 13:40:44 2024 +0200

    fix #230468 (#232040)

commit 45677a25581cd2b146a628c39d705f1de7b168cd
Author: Johannes Rieken <[email protected]>
Date:   Wed Oct 23 13:18:23 2024 +0200

    fix https://github.com/microsoft/vscode-copilot/issues/9382 (#232039)

commit 7bd727d20b8aae543fe100e24716bb9a0e12abd9
Author: Henning Dieterichs <[email protected]>
Date:   Wed Oct 23 13:14:51 2024 +0200

    Fixes https://github.com/microsoft/vscode-copilot/issues/9420 (#232038)

commit 84f315474088cea351959a5cba41ba545cd5b799
Author: Benjamin Pasero <[email protected]>
Date:   Wed Oct 23 13:10:57 2024 +0200

    Varying conditions when Copilot command center icon appears/disappears (fix microsoft/vscode-copilot#9459) (#232031)

commit 0a9f884f6afec72dd8ffa65b726e69d97ecf317f
Author: Henning Dieterichs <[email protected]>
Date:   Wed Oct 23 13:09:31 2024 +0200

    Fixes https://github.com/microsoft/vscode-copilot/issues/9359 (#232036)

commit 3d521abdd4517a127ffe3f3e3a91c480aec7eb07
Author: Johannes Rieken <[email protected]>
Date:   Wed Oct 23 12:56:56 2024 +0200

    add edit to chat menu (#232035)

    fix https://github.com/microsoft/vscode-copilot/issues/9619

commit ab9e24bbc6e4b3eb0e1a2c74859f9d6001bfa055
Author: Henning Dieterichs <[email protected]>
Date:   Wed Oct 23 12:51:27 2024 +0200

    Fixes https://github.com/microsoft/vscode-copilot/issues/9497 (#232034)

commit e748d4b90ff28c22e87da8e4dfff0a47dfce418a
Author: Henning Dieterichs <[email protected]>
Date:   Wed Oct 23 12:48:11 2024 +0200

    Show inline edit when cursor is close. Fixes a bug when inline edit is a line insertion. (#232033)

commit be6756eaa126039b239549e66c4864d3e4f39fcf
Author: Johannes Rieken <[email protected]>
Date:   Wed Oct 23 12:47:49 2024 +0200

    fixes https://github.com/microsoft/vscode-copilot/issues/9621 (#232032)

commit af78f5b27512b0f890903cebf3f6526a3aa2dc49
Author: Benjamin Pasero <[email protected]>
Date:   Wed Oct 23 11:27:27 2024 +0200

    fix: update distro version in package.json (#232022)

commit e5985ac7387674a1f0e7183bc990a3f71c75f6b7
Author: Benjamin Pasero <[email protected]>
Date:   Wed Oct 23 11:23:50 2024 +0200

    Update wording in Copilot command center install flow (fix microsoft/vscode-copilot#9457) (#232019)

commit 227d5a50f61567113438e74eda214c641bd0c97d
Author: Benjamin Christopher Simmonds <[email protected]>
Date:   Wed Oct 23 11:02:26 2024 +0200

    Compact badge for icons in panel title (#232020)

    compact badge for icons in panel title

commit cc652f829f759ff9c00c790d487c69f8fdc05dc5
Author: Benjamin Pasero <[email protected]>
Date:   Wed Oct 23 10:50:58 2024 +0200

    fix: enhance telemetry logging for chat installation process (#232016)

commit 9ef817c9c6c5799237fcbf362acb4869f73d7a2d
Author: Benjamin Christopher Simmonds <[email protected]>
Date:   Wed Oct 23 10:22:29 2024 +0200

    Fix tab header layout breaking in small editor groups (#232012)

    fixes #231776

commit 89d6652d8f895f097de8c6ebb06981f92e59a130
Author: Joyce Er <[email protected]>
Date:   Tue Oct 22 23:03:22 2024 -0700

    fix: tweak when clause for showing Save All in chat editing widget (#232000)

commit fe997185b5e6db94693ed6ef5456cfa4e8211edf
Author: Joyce Er <[email protected]>
Date:   Tue Oct 22 21:58:55 2024 -0700

    fix: don't store working set on chat input history (#232001)

commit 5cfef2c88d00a94ef7cd38d9017c951f99e25cfe
Author: Joyce Er <[email protected]>
Date:   Tue Oct 22 21:02:28 2024 -0700

    fix: only pick up text editors from Open Editors context (#231999)

commit 5bb29529f8e7b9d5da090fee31c592c0e132d029
Author: Peng Lyu <[email protected]>
Date:   Tue Oct 22 19:45:49 2024 -0700

    fix horizontal scroll on windows with shift key pressed. fixes #229441. (#231997)

commit 48fc69b9f767ca0c2b219d4ebf2125ddbb85e3dc
Author: Rob Lourens <[email protected]>
Date:   Tue Oct 22 18:22:37 2024 -0700

    Fix chat button colors (#231995)

    Fix #231992

commit bffc11aac8ff10c7924934ae5d31c9f2fd63df0e
Author: Joyce Er <[email protected]>
Date:   Tue Oct 22 17:30:48 2024 -0700

    fix: prompt when clearing an editing session with pending edits via New Edit Session (#231990)

commit 90ec60aa1043646773d50d8f9d861684c39ae7e1
Merge: 136762cf917 83e582f316f
Author: Andrea Mah <[email protected]>
Date:   Tue Oct 22 17:27:08 2024 -0700

    Merge pull request #231985 from microsoft/southern-galliform

    fix async refresh on clear results

commit 136762cf91752280957b0e5f24d8431526a8b505
Merge: e8b45be397c 888dd9b5387
Author: Andrea Mah <[email protected]>
Date:   Tue Oct 22 17:06:27 2024 -0700

    Merge pull request #231982 from microsoft/testy-goat

    try to reduce chance of duplicate headers

commit 83e582f316f6c22fa1d144c972665c7a2648bd0f
Author: andreamah <[email protected]>
Date:   Tue Oct 22 17:06:12 2024 -0700

    fix async refresh on clear results

commit 888dd9b53877d484874fcae2d8957d23e4b090f2
Author: andreamah <[email protected]>
Date:   Tue Oct 22 16:44:55 2024 -0700

    try to reduce duplicate headers

commit e8b45be397c9698fe919c30c9e866b65051b6069
Author: Matt Bierner <[email protected]>
Date:   Tue Oct 22 16:24:50 2024 -0700

    Enable copying the resource of symbol anchors (#231980)

commit 4224d78a27f544e30303adc464648403b456f2b0
Author: Joyce Er <[email protected]>
Date:   Tue Oct 22 13:34:42 2024 -0700

    fix: don't check for deprecated setting when enabling variables for terminal chat (#231965)

commit 2f0b38ff6191def5d2901e19f0250a9b784199b8
Author: Raymond Zhao <[email protected]>
Date:   Tue Oct 22 13:30:02 2024 -0700

    fix: too many info squiggles in settings.json (#231975)

commit 890985d7e345f1c4c1891942b3ba024ab1e2bf74
Author: Matt Bierner <[email protected]>
Date:   Tue Oct 22 11:42:16 2024 -0700

    Remove `(experimental)` from setting descriptions (#231963)

    Fixes #231958

commit a744313eb72ec82ca7986404ea8dc635068a5c25
Author: Hamir Mahal <[email protected]>
Date:   Tue Oct 22 09:30:46 2024 -0700

    style: simplify string formatting for readability (#231763)

    * style: simplify string formatting for readability

    * fix: formatting in `.rs` files in `src/`

commit aabb725c04d7d18f57855891d5c1782a68922890
Author: Joyce Er <[email protected]>
Date:   Tue Oct 22 09:00:17 2024 -0700

    fix: disable Edit with Copilot action in chat footer for now (#231952)

    fix: disable Edit with Copilot for now

commit 804f450ca900d24db25e7174e8b6dfb3fb2a318c
Author: Robo <[email protected]>
Date:   Tue Oct 22 22:26:13 2024 +0900

    fix: remote folder compilation on macOS with node.js v20.18.0 (#231928)

    * fix: remote folder compilation on macOS with node.js v20.18.0

    * chore: update debian deps

    * chore: update rpm deps

commit b79ff2ede04b8328dfa6ac23402a18a643eba20a
Author: Johannes Rieken <[email protected]>
Date:   Tue Oct 22 12:52:51 2024 +0200

    fix https://github.com/microsoft/vscode-copilot/issues/9509 (#231926)

commit c50ff3b53a8705c6f4b990cce164bbb44909ccdc
Author: Johannes Rieken <[email protected]>
Date:   Tue Oct 22 11:46:24 2024 +0200

    fix `LanguageModelChatMessage#User` so that it passes the true content down to the ctor (#231920)

commit 161661ce98b08f45a69a35edf88fc110da78eabc
Author: Martin Aeschlimann <[email protected]>
Date:   Tue Oct 22 11:23:44 2024 +0200

    new chat does not open the hidden chat view (#230137)

commit 527fc2dc7a4ee15f5eb7715075a972f275e6e674
Author: Martin Aeschlimann <[email protected]>
Date:   Tue Oct 22 10:56:07 2024 +0200

    move toolsParametersSchemaSchema to separate schema (#231852)

commit 6c2e9ffde13a2733e092fcb2f0c9c2bbcad25182
Author: Robo <[email protected]>
Date:   Tue Oct 22 17:12:06 2024 +0900

    chore: bump [email protected] (#231913)

    * chore: bump [email protected]

    * chore: bump distro

commit 3546da5f3f2e5dcba2a95749627069101cd8b91f
Author: SIHAN LI <[email protected]>
Date:   Tue Oct 22 03:46:45 2024 -0400

    Fix typo: context view anchor option might be dismissed when using `||` (#228896)

    Fix typo: context view anchor option might be dismissed

commit f1078dbf5263f5eab668133e4657f426e1ddaaeb
Author: Raymond Zhao <[email protected]>
Date:   Tue Oct 22 00:03:05 2024 -0700

    fix: some settings should be preview or stable (#231518)

commit defe52dc43e6f5d861f55600ff01f7553fac7eaf
Author: Joyce Er <[email protected]>
Date:   Mon Oct 21 21:21:42 2024 -0700

    fix: don't cut off chat editing multidiff icon when counterzoomed (#231907)

commit 90b4e9cf4497c4978ae1818c0b1e470fd322d056
Author: Matt Bierner <[email protected]>
Date:   Mon Oct 21 21:06:10 2024 -0700

    Make sure symbol links go to column locations too if provided (#231904)

commit bc0eb008a1b827fdf1dad6275c78ad4f1401d99d
Author: Rob Lourens <[email protected]>
Date:   Mon Oct 21 18:21:43 2024 -0700

    Finalize lmTools (#231788)

    * @returns

    * Finalize it

    * small tweaks

    * add `LanguageModelTextPart` to chat message and its factory functions

    * update `LanguageModelChatResponse` docs

    * more doc tweaks

    * LangModelChatMessage.content always array

    * Optional cancel token

    * parameters notes

    * Updates

    ---------

    Co-authored-by: Johannes Rieken <[email protected]>

commit 4f50e36812ff1a60b1efc46781a81a3060313720
Author: Robo <[email protected]>
Date:   Tue Oct 22 09:44:08 2024 +0900

    Revert "chore: enable coi on desktop (#231665)" (#231899)

    This reverts commit 71e53b72de83b3dd8f9aa9b3465bc89b4cc0aaa4.

commit 31b84027cb11466d6a2431d94c247631b967f5f5
Author: Joyce Er <[email protected]>
Date:   Mon Oct 21 17:31:42 2024 -0700

    fix: allow customizing keybinding for Add Files action in chat editing widget (#231893)

commit 17b703a0978be2b7b942d0bbed4568b9821aae41
Author: Matt Bierner <[email protected]>
Date:   Mon Oct 21 17:30:43 2024 -0700

    Fix command name for symbol anchor (#231898)

commit b298e164cb4a26744e89d3bef229480592547dfa
Author: Matt Bierner <[email protected]>
Date:   Mon Oct 21 17:28:35 2024 -0700

    Add `open to side` action for symbol anchors (#231897)

    Add `open to side` action for symbols

    Useful command and also prevents the symbol context menu from being empty if there are no active providers for the language

commit db90e51b7562f0707c55a1a894068f0e0c8ad199
Author: Matt Bierner <[email protected]>
Date:   Mon Oct 21 16:58:42 2024 -0700

    Bump issue notebook milestones (#231892)

commit d9f379b13576d04bac8679c446598539b99cbab3
Author: Rob Lourens <[email protected]>
Date:   Mon Oct 21 16:42:23 2024 -0700

    Finalize ChatRequest#model (#231811)

    * Finalize ChatRequest#model
    Fix #230844

    * Register model to fix tests

commit fb42702b12a1b8b2306d4bfe93e0561861435972
Author: Raymond Zhao <[email protected]>
Date:   Mon Oct 21 16:08:44 2024 -0700

    fix: missing aria labels for indicators (#231890)

commit 2990609dc843534b8c37fd2922c2b4ac48ed6274
Author: Joyce Er <[email protected]>
Date:   Mon Oct 21 15:56:47 2024 -0700

    feat: add a Done button to the chat editing widget (#231889)

commit 369da7c6fa2d3d269f0ef97b673e79bb37534358
Merge: 749d935de71 ebd1599e49f
Author: David Dossett <[email protected]>
Date:   Mon Oct 21 15:55:10 2024 -0700

    Merge pull request #231888 from microsoft/ddossett/historical-ox

    Adopt new edit session icon for edit view

commit ebd1599e49f6b146fdbc0dc0ad8564c002548497
Author: David Dossett <[email protected]>
Date:   Mon Oct 21 15:40:43 2024 -0700

    Adopt new edit session icon for edit view

commit 749d935de716c19ec24471c48c747b125fce1f7e
Merge: dedff8bfdbd eb3142cca8f
Author: David Dossett <[email protected]>
Date:   Mon Oct 21 15:09:47 2024 -0700

    Merge pull request #231884 from microsoft/ddossett/compulsory-angelfish

    Update codicons and add `code-review`

commit eb3142cca8fbfc0761886dbeebe2959312f22566
Author: David Dossett <[email protected]>
Date:   Mon Oct 21 14:53:45 2024 -0700

    Update codicons and add `code-review`

commit dedff8bfdbd7477d9b9a9cd8a239de46eb7eaa5c
Author: Joyce Er <[email protected]>
Date:   Mon Oct 21 14:40:30 2024 -0700

    fix: don't overwrite pending chat editing snapshots while restoring snapshots (#231881)

commit f377b8c7c8def7fc9037aea2fd338eb4aad596ba
Author: Andrea Mah <[email protected]>
Date:   Mon Oct 21 14:28:47 2024 -0700

    Persist AI results upon button toggle (#230443)

    * keep AI search results if it is unaffected by the change

    * restore work on search model

commit 0698de01855d771a8e3f97551f0444644f6544f7
Author: Joyce Er <[email protected]>
Date:   Mon Oct 21 13:15:55 2024 -0700

    feat: hide undone requests in the chat UI (#231877)

    * Add a field which reflects the currently undone requests

    * Hide requests and responses that were undone in the UI

    * Delete any requests which were undone from the underlying model when a new request is submitted

    * Align snapshot action names

    ---------

    Co-authored-by: Alex Dima <[email protected]>

commit 9408e18ba5da13d6955a1f9d7dac0759d881f7cd
Author: Bhavya U <[email protected]>
Date:   Mon Oct 21 13:14:29 2024 -0700

    Remove unused chat getting started contribution and related imports (#231870)

commit 4ac5fc3fe7a36d849532c9ab5df4464d77ef9a78
Author: Andrea Mah <[email protected]>
Date:   Mon Oct 21 13:05:15 2024 -0700

    add copilot icon beside copilot results node (#230561)

    * add copilot icon beside copilot results node

    * add todo

commit d5baf34009da435440459e73f07a6c19164e9fbe
Author: Raymond Zhao <[email protected]>
Date:   Mon Oct 21 12:48:49 2024 -0700

    Revert "fix: CLI is missing guard:cf flags" (#231874)

    Revert "fix: CLI is missing guard:cf flags (#231863)"

    This reverts commit 1e580bc97d257512ac07b494d485b877a2d3372c.

commit f5ac6168e08525535f3c4311a45c57f949891690
Merge: 2a98b756b20 0729b0fb6f8
Author: Andrea Mah <[email protected]>
Date:   Mon Oct 21 12:04:09 2024 -0700

    Merge pull request #231873 from microsoft/andreamah/issue231399

    Put `hasNode` check if refreshing particular elements

commit 2a98b756b20a66338aaf39c4deb54f9e819fe076
Author: Andrea Mah <[email protected]>
Date:   Mon Oct 21 11:59:03 2024 -0700

    Search - collapsed nodes take multiple expansions (#231872)

    Fixes #231602

commit d3bb5dd92f171a54b7f675ea01fb4c2b28b51324
Author: Raymond Zhao <[email protected]>
Date:   Mon Oct 21 11:55:36 2024 -0700

    chore: publish symbols internally (#231869)

commit 0729b0fb6f8478171ba3b5c22de81f83ba6efdcc
Author: andreamah <[email protected]>
Date:   Mon Oct 21 11:46:16 2024 -0700

    Put `hasNode` check if refreshing particular elements
    Fixes #231399

commit 1e580bc97d257512ac07b494d485b877a2d3372c
Author: Raymond Zhao <[email protected]>
Date:   Mon Oct 21 10:53:34 2024 -0700

    fix: CLI is missing guard:cf flags (#231863)

commit 7cdb7ee9df511ac3b6586be865219f49ed858d8b
Author: Tyler James Leonhardt <[email protected]>
Date:   Mon Oct 21 10:42:46 2024 -0700

    Bump da distro (#231860)

    distro UP

commit 60311c31f80a642bfcb14d110cd56bb9da47915a
Merge: ecf3f0e6d6b 7ab1b3e8859
Author: David Dossett <[email protected]>
Date:   Mon Oct 21 10:41:15 2024 -0700

    Merge pull request #231859 from microsoft/ddossett/square-kangaroo

    Update codicons and use edit session icon

commit 7ab1b3e885968c5b8fbd27c891e12838ca57dd98
Author: David Dossett <[email protected]>
Date:   Mon Oct 21 10:19:07 2024 -0700

    Update codicons and use edit session icon

commit ecf3f0e6d6bbd736bc04927aab2f792259df89d9
Author: Matt Bierner <[email protected]>
Date:   Mon Oct 21 10:09:32 2024 -0700

    Pick up latest TS for building VS Code (#231857)

commit 1e696c1075f564361cd1feacafb22ca01a0db9e4
Author: Justin Chen <[email protected]>
Date:   Mon Oct 21 17:00:06 2024 +0000

    bump distro (#231854)

commit d0dcbfccc195e39bcef9eedb67d8868bcc06d0b4
Author: Matt Bierner <[email protected]>
Date:   Mon Oct 21 09:59:31 2024 -0700

    Small spelling fixes in vscode.d.ts (#231856)

commit 15e9455b8fafb15c945b9ca57875fe3f2a668d89
Author: Henning Dieterichs <[email protected]>
Date:   Mon Oct 21 18:35:29 2024 +0200

    inline edits: implements extension contributable commands (#231850)

commit f00458a1522de23818cc1871036a40adb1a50cea
Author: Benjamin Pasero <[email protected]>
Date:   Mon Oct 21 17:56:13 2024 +0200

    chat - keep storage key updated for chat installation status (#231847)

commit 44adad347c2d6e5c21f351d1d2b0f23b8b60f820
Author: Henning Dieterichs <[email protected]>
Date:   Mon Oct 21 17:41:50 2024 +0200

    Fixes disposable leak (#231846)

commit 2772c1d92755c6f376b57893b42e84d95dd8e23c
Merge: 0de9ec3a26f 1dd002b643a
Author: Sandeep Somavarapu <[email protected]>
Date:   Mon Oct 21 17:37:57 2024 +0200

    Merge pull request #229454 from trevor-scheer/main

    Marker message white-space `nowrap` -> `pre`

commit 0de9ec3a26f98fd682bd019a953827a86a930374
Merge: 6fc6135e6e5 d8fe57675ed
Author: Isidor Nikolic <[email protected]>
Date:   Mon Oct 21 17:30:44 2024 +0200

    Merge pull request #231844 from microsoft/isidorn/prospective-bonobo

    update distro pointer

commit 6fc6135e6e53793bbf6cbc71d92fe681295ac78c
Author: Benjamin Christopher Simmonds <[email protected]>
Date:   Mon Oct 21 17:20:38 2024 +0200

    Improve error logging for missing tree nodes (#231843)

    log node which is throwing

commit d82b96f1f84adf0a055734f0ceb01a67cea43dda
Author: Henning Dieterichs <[email protected]>
Date:   Mon Oct 21 17:09:33 2024 +0200

    Improves inline edit colors (#231841)

commit d8fe57675edaee89f5e27d281626ccef54134efd
Author: isidorn <[email protected]>
Date:   Mon Oct 21 17:08:01 2024 +0200

    update distro pointer

commit b2224244ba18041b0930988ab8cf69b31a7bed49
Author: Alexandru Dima <[email protected]>
Date:   Mon Oct 21 17:05:14 2024 +0200

    Add undo/redo to chat editing pane (#231840)

commit 7e0d5fa3338305076f6009fb5cf1fb3e1d5b672d
Author: Sandeep Somavarapu <[email protected]>
Date:   Mon Oct 21 16:41:38 2024 +0200

    fix #230260 (#231838)

commit f84b345a46dacbf7e77c4734a94a4cdab91add72
Author: Robo <[email protected]>
Date:   Mon Oct 21 22:37:26 2024 +0900

    ci: cleanup snap publishing step (#231833)

commit 92e6d3b917ec7378c656b7c31e7f2031f58468d0
Author: Henning Dieterichs <[email protected]>
Date:   Mon Oct 21 13:13:53 2024 +0200

    improves inline edit rendering (#231828)

commit 71e53b72de83b3dd8f9aa9b3465bc89b4cc0aaa4
Author: Robo <[email protected]>
Date:   Mon Oct 21 19:59:36 2024 +0900

    chore: enable coi on desktop (#231665)

commit 902710e3342c0e0228cab6a4e9e431993e9396ee
Merge: 48c7be5dc5a 16ff8ed9ac9
Author: Alexandru Dima <[email protected]>
Date:   Mon Oct 21 12:58:02 2024 +0200

    Merge pull request #231824 from microsoft/alexd/handsome-egret

    Fix issues around restoring snapshots

commit 16ff8ed9ac9ffa2f979429ecf2adb8e6ec4501c7
Author: Alex Dima <[email protected]>
Date:   Mon Oct 21 12:43:12 2024 +0200

    Spell out all arguments, don't do default values

commit 2b45eaec85b3009d53334651ef39de4248c6b347
Author: Alex Dima <[email protected]>
Date:   Mon Oct 21 12:42:44 2024 +0200

    Don't transpose edits and recompute diffs when restoring snapshots

commit 48c7be5dc5af8c9e2e3e4fef98f9218f465a9467
Author: Benjamin Pasero <[email protected]>
Date:   Mon Oct 21 12:03:28 2024 +0200

    fix: adjust zoom factor for menu and toolbar positioning in titlebar (#231825)

commit 104f0ac9dbdb33d27a7833dd2916cd0d18cf40ad
Author: Alex Dima <[email protected]>
Date:   Mon Oct 21 11:36:12 2024 +0200

    Group chat editing files together

commit c91c7b6c586f368772560d6a9815538fe46f3f2e
Author: Alex Dima <[email protected]>
Date:   Mon Oct 21 11:35:31 2024 +0200

    Split up `chatEditingService.ts`

commit 31ea6e5ce993aac195cff910106cf8dadb3cb276
Author: Johannes Rieken <[email protected]>
Date:   Mon Oct 21 10:58:26 2024 +0200

    only one ask for all saves (#231821)

commit 33c0bfa0375c57f0ac144c93ebbec1d78f0eca07
Author: Johannes Rieken <[email protected]>
Date:   Mon Oct 21 10:13:04 2024 +0200

    enable model picker for inline chat (#231817)

    https://github.com/microsoft/vscode-copilot/issues/9304

commit 8ec9d668d542e3f7775f2fd159c0879651ddc3be
Author: Alex Ross <[email protected]>
Date:   Mon Oct 21 09:36:19 2024 +0200

    VSCode DDoS itself discovering ports for the tunnel feature (#231668)

    * VSCode DDoS itself discovering ports for the tunnel feature
    Fixes #230738

    * Expand limit

commit 75caed98f2ffb9e0657001af4cd0aee5bb938a84
Author: Raymond Zhao <[email protected]>
Date:   Sun Oct 20 22:08:45 2024 -0700

    chore: install make for snap (#231709)

    * chore: install make for snap

    * Also add g++

    * Also list versions

    * Again

commit 27d99fbee7c41ce8fb5d59c461cc6e2f8d383072
Author: Don Jayamanne <[email protected]>
Date:   Mon Oct 21 15:56:16 2024 +1100

    Set execution_count to null when clearning notebook outputs (#231806)

    * Set execution_count to null when clearning notebook outputs

    * Fix tests

commit 05ff1fda3cfa97a7e466f36d5b39e9eb8da7e305
Author: Rob Lourens <[email protected]>
Date:   Sun Oct 20 19:38:14 2024 -0700

    Restore viewport context when no selection (#231804)

    Was including the full file, after the implicit context widget was added. This sends a Location as the reference value for the current viewport.

commit 235982f24082589c7fa1ee41374e0c844ebb54d7
Author: Joyce Er <[email protected]>
Date:   Sun Oct 20 17:59:31 2024 -0700

    chore: run OSS tool (#231800)

    * chore: run OSS tool

    * 🆙distro

commit 7a4db2f0bf14ba24772f98962920cb1380418118
Author: Rob Lourens <[email protected]>
Date:   Sun Oct 20 17:54:13 2024 -0700

    Disable implicit context in edit view (#231801)

    Disable implicit context in other views
    Mixup from #231705

commit f785a170b62948dad455a07cfb6f326829e274e4
Author: Matt Bierner <[email protected]>
Date:   Sun Oct 20 17:33:16 2024 -0700

    Small fixes to inline anchor (#231798)

    - Don't hold on to text mode
    - Only update context when it's needed
    - On click, just go to line instead of selecting range
    - Don't show actions at all if there is no provider for them

commit b87039d5e2380e888ec471f427df68c12e0463ec
Author: Benjamin Pasero <[email protected]>
Date:   Sun Oct 20 17:54:43 2024 +0200

    :up: distro (#231787)

commit d1c2ee820e707565579b379525de1a7711b22edf
Author: Benjamin Pasero <[email protected]>
Date:   Sun Oct 20 17:45:51 2024 +0200

    aux window - fix status not showing on startup for notebooks (#231786)

commit 42b425bc8ea39b56e61d303a60329249d328b2c8
Author: Benjamin Pasero <[email protected]>
Date:   Sun Oct 20 17:29:33 2024 +0200

    Offer chat install experience for entitled users (#231287)

commit d72a0f0af6edf3601ec95328755841695aa300dd
Author: Rob Lourens <[email protected]>
Date:   Sat Oct 19 13:56:56 2024 -0700

    Round of lmTools docs (#231745)

commit 84f4e213b636570c522583641a3442a082754e37
Author: Andrea Mah <[email protected]>
Date:   Fri Oct 18 18:36:37 2024 -0700

    add throttle to search refresh (#231533)

commit 1e20d8200bdbade3fe7ad6b55b685e77adf64c57
Author: Andrea Mah <[email protected]>
Date:   Fri Oct 18 18:34:53 2024 -0700

    create folderQuerySearchTree (#231715)

    Fixes https://github.com/microsoft/vscode/issues/227836

commit b466b4c2e97e97292baf103163b754dadeb5dd73
Author: Matt Bierner <[email protected]>
Date:   Fri Oct 18 17:42:58 2024 -0700

    Add more commands to symbol anchors (#231713)

    Adds support for `go to implantation` and `go to type definition`

commit 7f42527b25f3814deb24720756c321946a8149fe
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 18 16:34:37 2024 -0700

    Fix non-chat panel tool confirm dialog (#231712)

commit 64d1de414d8b7cae7a266fd66fd3d73522bc30fa
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 18 16:34:23 2024 -0700

    Fix chat attachment container resizing (#231711)

    - Don't render attachments during layout. It's async and always gets sized to the height of one attachment because that's all that has rendered
    - Measure oldHeight before disposing previously rendered things
    - Don't fire onDidChangeHeight immediately when the button is clicked, this also starts a layout while a render is happening

commit f94a65c30400458d4d863455407e4793f63bf227
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 18 15:58:58 2024 -0700

    Implement "send and dispatch" (#231689)

    * Implement "send and dispatch"

    * Fix build

    * Caps

    * id

commit 05f148d813254400e22d04c29f38370c4ca4b80c
Author: Joyce Er <[email protected]>
Date:   Fri Oct 18 15:52:18 2024 -0700

    fix: prompt for undo and retry edits only if the request did edits (#231710)

    * fix: update request ID for subsequent chat edits to the same file

    * fix: prompt for undo and retry edits only if the request did edits

    * fix: be more specific about what edits will be undone in dialogs

commit dc43276eb6b2c2bd41fcb3e8a43f7215220ff96c
Author: Matt Bierner <[email protected]>
Date:   Fri Oct 18 15:40:19 2024 -0700

    Fix scaling of symbol anchor icons (#231706)

commit ae38d8afaac712f7a6c3dd1b1ea6bc1de6c9f895
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 18 15:09:16 2024 -0700

    Fix "Cannot read properties of undefined (reading 'implicitContext')" (#231705)

    Don't try to set the context before the widget is fully rendered. Also, be a little more conservative in not setting up the implicit context on non-panel chat widgets

commit 343e21b1bbb92b2231641e49ba5f0a1ef8aa8697
Merge: 40eeca9ef94 997f705e034
Author: Connor Peet <[email protected]>
Date:   Fri Oct 18 15:00:24 2024 -0700

    Merge pull request #231703 from microsoft/connor4312/fix-breakpoint-condition-edit

    debug: fix edit breakpoint condition input not appearing

commit 40eeca9ef94a7339ed54adfc06ef4a845f2d210f
Author: Joyce Er <[email protected]>
Date:   Fri Oct 18 14:58:25 2024 -0700

    fix: include `#file` variables in chat working set (#231692)

    * fix: include `#file` variables in chat working set

    Also fix attachment rendering in regular chat requests

    * refactor: simplify `IChatEditingService` interface

    * fix: `#file` references earlier in an editing session should be sent as attachments in subsequent `ChatRequest`s

commit a1f9581cb149ebd89d17e0b6ba2ce00dca81619e
Author: Joyce Er <[email protected]>
Date:   Fri Oct 18 14:24:29 2024 -0700

    fix: don't show Open File Checkpoint in latest response code block context menu (#231701)

commit 997f705e03414a6c0ce19f2caa7ac28ef83a63a4
Author: Connor Peet <[email protected]>
Date:   Fri Oct 18 14:21:47 2024 -0700

    debug: fix edit breakpoint condition input not appearing

    Closes #230631

commit 7aad6874fc707f95eef0a4196d4b499bb9c111ec
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 18 14:14:20 2024 -0700

    Sort models in picker (#231700)

commit e8c1e6c2d0d1b8eefb51a46e0c4760b08bb9fa47
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 18 14:06:31 2024 -0700

    Use hardcoded json schema for tools parametersSchema (#231699)

    This doesn't support full JSON schema, just a subset with some restrictions, so we use our own definition here so that extension authors can have a good experience.
    Fix #225727

commit bcf6a6af1c18a27b00069f7713d8bc063bcadc33
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 18 14:05:43 2024 -0700

    Add LanguageModelIgnoredFileProvider (#231696)

commit 21219a938e53331e388e6f67f9393e954c511dae
Author: Rob Lourens <[email protected]>
Date:   Fri Oct 18 13:31:58 2024 -0700

    lmTools API updates and LanguageModelPromptTsxPart (#231544)

    * Try LanguageModelToolResultItem

    * Implement it

    * lmTools API updates
    Resolve TODOs

    * Fix build

    * Doc

    * More content type -> mime type

    * More edits

    * Fixes

    * Add LanguageModelChatToolMode

    * Add implementation

    * New thing

    * note

    * API version bump

    * Finish it

    * Updates

    * Properly convert tool result content parts

commit 18c982552dad7f27124060ba25ce6ea0fb3ee92c
Author: Justin Chen <[email protected]>
Date:   Fri Oct 18 19:32:17 2024 +0000

    remove setting for image attachments (#231620)

    * remove setting for image attachments

    * check for extension enabled proposed api

    * whitespaces

commit 759c92ba74b1d536bd1e023d6581812845334fc2
Author: Matt Bierner <[email protected]>
Date:   Fri Oct 18 11:53:18 2024 -0700

    Bump dompurify versions (#230250)

commit 5dd9db33e121375f65c30108ac40af57b55b05fc
Author: Joyce Er <[email protected]>
Date:   Fri Oct 18 11:47:36 2024 -0700

    fix: clicking the code block pill opens the latest, context menu action opens the checkpoint (#231688)

commit 277082ff93a9246581e9ac3e0a0fb6b2c5a08b93
Author: yanglb <[email protected]>
Date:   Sun Oct 6 14:33:18 2024 +0800

    add type checking to decorators

commit d93dd05c5129362d8c560e152d8957b80f1f009b
Merge: 587ccd9b59e 67fde362ab2
Author: Andrea Mah <[email protected]>
Date:   Fri Oct 18 10:49:18 2024 -0700

    Merge pull request #231683 from microsoft/hot-penguin

    fix await on `onSearchResultsChanged()`

commit 67fde362ab23e7b77fa833b29821d51e6561e251
Author: andreamah <[email protected]>
Date:   Fri Oct 18 10:33:22 2024 -0700

    fix await on `onSearchResultsChanged()`

commit 587ccd9b59ec6d585368be9ff1a7953600d16174
Author: Joyce Er <[email protected]>
Date:   Fri Oct 18 09:19:43 2024 -0700

    fix: remove bad hover background in light theme on Open Diffs editing widget action (#231678)

commit 2e9fc2a8deba985b18e8fd9c352a7dc766dc28de
Author: Henning Dieterichs <[email protected]>
Date:   Fri Oct 18 17:58:49 2024 +0200

    inline edit adjustments (#231677)

commit 442bada913f8db053ac2bb8521a31c50e7828905
Author: Joyce Er <[email protected]>
Date:   Fri Oct 18 08:31:13 2024 -0700

    fix: better fix for transient edits being tracked after a request is sent (#231675)

    * fix: better fix for transient edits being tracked after a request is sent

    * fix: look for correct autosave setting value

commit 8491f5724fe930cef67c40a2c5c05d2f4d5c2ee5
Author: Joyce Er <[email protected]>
Date:   Fri Oct 18 08:02:43 2024 -0700

    fix: use `cursor: pointer` for code block pills (#231670)

commit 07933a094576cacb8dc1e53163f575c8331732e4
Merge: ab537a191e8 5e915ce4f3e
Author: Alexandru Dima <[email protected]>
Date:   Fri Oct 18 16:31:10 2024 +0200

    Merge pull request #231648 from microsoft/alexd/slimy-urial

    Improvements for Chat Edits

commit 5e915ce4f3e6f191118bfbbcf2f6d6c7268970c4
Author: Alex Dima <[email protected]>
Date:   Fri Oct 18 16:03:01 2024 +0200

    Add overview decorations

commit ab537a191e8c380ee719ea7cd9849dad81ad329c
Author: Henning Dieterichs <[email protected]>
Date:   Fri Oct 18 16:00:22 2024 +0200

    Fixes casing (#231663)

commit 686be7f6760ddc2596f003be3dccb542d8486086
Author: Alex Dima <[email protected]>
Date:   Fri Oct 18 15:38:12 2024 +0200

    Keep the current editing line decoration for longer

commit 9abbed01bf5c62effb155d1e2969c1d2e277c842
Author: Alex Dima <[email protected]>
Date:   Fri Oct 18 15:23:56 2024 +0200

    Add transactions

commit 0ff5e9288a6536306fda3ba9860734c0742f2452
Author: Alex Dima <[email protected]>
Date:   Fri Oct 18 15:23:49 2024 +0200

    Use observables for the file spinners

commit 8080d34598a3dd76c16e878fee1cec1c3e196445
Author: Henning Dieterichs <[email protected]>
Date:   Fri Oct 18 14:04:27 2024 +0200

    implements inline diff view of inline edits (#231650)

commit 0de652b7ffe9395f9f86363b2dccdd5f93f6958b
Author: Benjamin Christopher Simmonds <[email protected]>
Date:   Fri Oct 18 12:52:51 2024 +0200

    Update tree-sitter package-lock.json (#231646)

    update tree sitter package-lock.json

commit 57690c89fc0e8a1cb607f97242bbb92a392c99d8
Author: Alex Dima <[email protected]>
Date:   Fri Oct 18 12:18:47 2024 +0200

    The working set should always contain the edited files

commit 8cb495dcb06ac3e9a8c4fb5971490dd5ece103b9
Author: Alex Dima <[email protected]>
Date:   Fri Oct 18 12:13:36 2024 +0200

    Fix dangerous pattern

commit 01b76db94e6d0ed8d75f50fa6a73f389ba8b576d
Author: Alex Dima <[email protected]>
Date:   Fri Oct 18 12:12:39 2024 +0200

    Remove unnecessary property

commit a77885d9e879023f87c852d5f089efb1399a3e75
Author: Benjamin Christopher Simmonds <[email protected]>
Date:   Fri Oct 18 11:54:30 2024 +0200

    Fix caching bug with multiple workspaces (#231645)

    fix caching bug with multiple workspaces

commit 3906f4cacce8bf9dcbc08f5372a517dd290b396e
Author: Alex Ross <[email protected]>
Date:   Fri Oct 18 10:52:12 2024 +0200

    Make tree-sitter a required dependency for build (#231494)

commit a927701f5f96f18789be766ef08f72bd32996c49
Author: Henning Dieterichs <[email protected]>
Date:   Fri Oct 18 10:28:20 2024 +0200

    Introduces editor.inlineSuggest.edits.experimental.enabled (default true). (#231592)

    * Introduces editor.inlineSuggest.edits.experimental.enabled (default true).

    Replace editor.inlineSuggest.experimentalInlineEditsEnabled.

    * updates monaco.d.ts

commit 77cbc136f00b8fa773cba933963f8a1df4e0b1d3
Author: Joyce Er <[email protected]>
Date:   Thu Oct 17 22:56:36 2024 -0700

    fix: adopt `MenuWorkbenchButtonBar` in chat editing widget (#231635)

commit c85acdad6b679973c79b01a38afa91448c705c1c
Author: Joyce Er <[email protected]>
Date:   Thu Oct 17 18:10:56 2024 -0700

    fix: prompt to take action on pending edits when starting a new chat editing session (#231622)

    * fix: prompt to take action on pending edits when starting a new chat editing session

    * fix: make sure to clear existing editing session history when starting a new editing session

commit a4e21784b0de2b53ea6c1ab25b395d97edee5939
Author: Don Jayamanne <[email protected]>
Date:   Fri Oct 18 11:22:25 2024 +1100

    Update distro commit hash (#231617)

commit 950b401a9cc504540168b2e010d3b28f10a71a72
Author: Tyler James Leonhardt <[email protected]>
Date:   Thu Oct 17 16:36:06 2024 -0700

    Make multiple accounts the default (#231618)

commit 83f64ef6bb290215b0243a17efd343e2fa6d37bf
Author: Bhavya U <[email protected]>
Date:   Thu Oct 17 15:53:14 2024 -0700

    fix: walkthrough restore and page title (#231616)

commit 9d032955ff45f25951de95077851c5a36263280e
Author: Justin Chen <[email protected]>
Date:   Thu Oct 17 22:48:32 2024 +0000

    loading for code actions (#231608)

    add loading for code actions selected

commit 3b1b283baa09753d9c6c92135ec4cc7939f11a58
Author: Joyce Er <[email protected]>
Date:   Thu Oct 17 15:16:33 2024 -0700

    fix: don't render request attachments which are also in the working set (#231614)

commit c85cd6d490378165ca78f79b045321ababf2f40b
Author: Joyce Er <[email protected]>
Date:   Thu Oct 17 13:49:40 2024 -0700

    fix: don't track active editors once chat has edits (#231610)

commit 41359a27005cce32f005e7e17b67374d592b2b61
Author: Joyce Er <[email protected]>
Date:   Thu Oct 17 13:32:42 2024 -0700

    fix: make disabled request blur less aggressive (#231607)

    * fix: don't render the chat editing widget offset from the input

    * fix: make disabled request blur less aggressive

commit 088471eeb232c660f6000e0cfcc4bb664feef5d1
Author: Joyce Er <[email protected]>
Date:   Thu Oct 17 11:23:04 2024 -0700

    fix: set focus to chat input once user is done attaching context

commit 31df71478c8abb9c296f3760bff9d227ad471b8b
Author: Joyce Er <[email protected]>
Date:   Thu Oct 17 11:10:47 2024 -0700

    fix: bring back Restore Previous File State behind an experimental setting

commit 392966c5672a93ce1282e72acf5951b09950a777
Author: Joyce Er <[email protected]>
Date:   Thu Oct 17 11:07:22 2024 -0700

    fix: blur disabled requests and responses

commit a4e98a9da8dbe180bd07610bc329618e374d1d66
Author: Joyce Er <[email protected]>
Date:   Thu Oct 17 10:58:08 2024 -0700

    fix: use X for Undo Edits in request, remove from footer

commit a56879c50db91715377005d6182d12742d1ba5c7
Author: Matt Bierner <[email protected]>
Date:   Thu Oct 17 11:36:20 2024 -0700

    Use stable id for inline refs (#231605)

    This does not need to be globally unique, only unique in the stream

commit 4428a025b23c61fd6b52a344c995e630a2dfdbca
Author: Raymond Zhao <[email protected]>
Date:   Thu Oct 17 09:17:44 2024 -0700

    chore: add BinSkim for CLI (#231543)

commit 4270673db749cda5bd268a2ae0d289a1a9eec4cb
Author: Henning Dieterichs <[email protected]>
Date:   Thu Oct 17 18:15:36 2024 +0200

    Dont collapse inline edits (#231599)

commit 10dc5effcf7b2dbb10106882929a3a5982b0bd65
Author: Henning Dieterichs <[email protected]>
Date:   Thu Oct 17 18:14:44 2024 +0200

    dont hide inline edits on blur (#231596)

commit 5c83a6768ee9441c4f2ccf47b898dd76f68e4af2
Author: Henning Dieterichs <[email protected]>
Date:   Thu Oct 17 18:13:42 2024 +0200

    Dont throw on cyclic observable dependencies until diff editor issue is fixed (#231594)

commit 66651f2f40228c242deb416d9e06cbe513771aa8
Author: Henning Dieterichs <[email protected]>
Date:   Thu Oct 17 16:52:26 2024 +0200

    Removes the old inlineEdit feature (now part of the inline suggest feature) (#231590)

commit f3617c1b54aa0ad80d4a4fc5307d0f9520f146b2
Author: Benjamin Christopher Simmonds <[email protected]>
Date:   Thu Oct 17 11:59:26 2024 +0200

    Remove redundant event firing for group maximization state (#231570)

    fix: remove redundant event firing for group maximization state

commit 62a233cc87dc8d52a817739bc0d917089d4d103b
Author: Bhavya U <[email protected]>
Date:   Wed Oct 16 17:12:24 2024 -0700

    Support showing walkthrough page titles (#231546)

commit 8addf834f8b205756d0c7bd88a6bec3c1927523d
Author: 夜坂雅 <[email protected]>
Date:   Thu Oct 17 08:02:59 2024 +0800

    fix: Use a proper desktop name in package.json (#231472)

    Fixes #154693

    Initally, this part is required due to how Electron handles the prorotol
    registeration as in https://github.com/microsoft/vscode/pull/56727#issuecomment-420701045 ( I also explained in https://github.com/microsoft/vscode/issues/154693#issuecomment-2409830275 )

    However since
    https://github.com/microsoft/vscode/commit/986b5532b5df1b95517f1ab134c19e8490e6a825
    that part is no longer used for protocol registeration on Linux, and
    since Electron 18, Electron uses the desktop file name to set the
    `app_id` in Wayland, and it was given the wrong one. This change fixes the
    problem where running VS Code on Wayland would have the `app_id` of
    `code-url-handler` which is unreasonable.

commit 20c108c938ff2febaa07ba0cb14b833d9224daed
Author: Rob Lourens <[email protected]>
Date:   Wed Oct 16 16:57:04 2024 -0700

    Chat input completions tweaks (#231540)

    Make / work more similarily to how it did before

commit 5cd08236ffc1f480f6d26d249b6336d67d14ab79
Author: Rob Lourens <[email protected]>
Date:   Wed Oct 16 16:30:43 2024 -0700

    Tweaks to welcome view and "Install chat extensions" suggestion (#231539)

    * Tweaks to welcome view and "Install chat extensions" suggestion

    * Fix

commit e7ff74e10daed642a4485c326c52cd7942c55817
Merge: af9058db263 da4f507d418
Author: Connor Peet <[email protected]>
Date:   Wed Oct 16 15:33:42 2024 -0700

    Merge pull request #231538 from microsoft/connor4312/testing-polish

    testing: various polish items

commit da4f507d4185b9cce4809da71df4da0d894e3a65
Author: Connor Peet <[email protected]>
Date:   Wed Oct 16 15:09:54 2024 -0700

    testing: select item in results when selected in explorer

commit af9058db263a27acf367234756a1c13daf4d1fe9
Author: Matt Bierner <[email protected]>
Date:   Wed Oct 16 14:47:33 2024 -0700

    Try to avoid writing full inline refs blobs to markdown stream (#231535)

    Instead of writing all the inline reference metadata as a fake markdown link, this switches to write out a fake link with just a id path. We can then use this to look up the actual metadata

commit 7cc1b4329f4009000646b9cb855851db59b282dc
Author: Joyce Er <[email protected]>
Date:   Wed Oct 16 14:36:59 2024 -0700

    fix: disable chat editing secondary execute action if there are no file attachments (#231534)

    * fix: disable chat editing secondary execute action if there are no file attachments

    * fix: better Continue Editing label

commit 75eb873e7d6e1329728a6a1e59e50ffe1562d72a
Author: Andrea Mah <[email protected]>
Date:   Wed Oct 16 14:34:57 2024 -0700

    Add new AI textSearchHeading UI with ranges (#231455)

    * try to add new AI textSearchHeading

    * finish connecting ai results UI

    * cleaning up and fixing tests

    * rename dir

    * revert heading

commit 86aab25210557e9a08abdc88b7fa768354209c8a
Author: Matt Bierner <[email protected]>
Date:   Wed Oct 16 14:17:04 2024 -0700

    Redirect TS report issue to issue reporting guide (#231527)

    Almost none of the issues that come in through our `report issue` button are actionable. Previously more people were filling in the template and following up, but now very few do

    So instead, I'm changing this to open a guide about the common causes of crashes and how to file a good issue report. This guide also focuses on helping people self-diagnose and fix problems

commit 2dac28facafb324d5efb436f5a4e2d59bb3e853a
Merge: 6de91b15990 bd1fd9f59a7
Author: David Dossett <[email protected]>
Date:   Wed Oct 16 14:01:05 2024 -0700

    Merge pull request #231532 from microsoft/ddossett/molecular-sparrow

    Align pill styling

commit bd1fd9f59a7871199d7bafcec8a417b4d0b8ab11
Author: David Dossett <[email protected]>
Date:   Wed Oct 16 13:45:58 2024 -0700

    Align pill styling

commit 30d584dd0d0f1a4451356df6130842f2deb849d7
Author: Connor Peet <[email protected]>
Date:   Wed Oct 16 12:48:52 2024 -0700

    testing: improve inline actions in test results tree

commit f984cca9b5fe709ac148a497d7ba831a5560a28f
Author…
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
October 2024
Development

Successfully merging a pull request may close this issue.

Show a modal when an extension has not yet used an account microsoft/vscode
3 participants
@TylerLeonhardt @rzhao271 @bamurtaugh