Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Settings editor language filter and override notes #5248

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

rzhao271
Copy link
Contributor

Refs microsoft/vscode#136068 (comment), and the fact that I also learned more about settings precedence last week from Sandeep.
Additionally, refs microsoft/vscode#58038, and the fact that part of that issue has been fixed, so part of the docs is now unnecessary and incorrect.

We can merge these notes into vnext, because the Settings editor language filter feature and the fix for 58038 are not in Stable yet.

This PR does two things:

  • It adds notes on language filters in the Settings editor
  • It refines the notes on settings precedence, and also considers remote and language-specific scopes.

@rzhao271 rzhao271 added this to the March 2022 milestone Mar 21, 2022
@rzhao271 rzhao271 requested a review from gregvanl March 21, 2022 23:23
@rzhao271 rzhao271 self-assigned this Mar 21, 2022
@gregvanl gregvanl merged commit 31bd942 into vnext Mar 22, 2022
@gregvanl
Copy link

Thanks!
I had to resolve several merge conflicts due to my updates to settings.md in main. I think I did it correctly but I'll do another review of your changes so that I got everything

@rzhao271 rzhao271 deleted the rzhao271/settings-override-notes branch February 22, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants