Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested specificity fix #311

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Nested specificity fix #311

wants to merge 7 commits into from

Conversation

GauravB159
Copy link
Contributor

Fix for issue #309

All tests were passing except one, which it seems was using the old specificity value in the assertion. I have changed that to the correct value.

@aeschli
Copy link
Contributor

aeschli commented Nov 9, 2022

Can you add test cases that cover the new code?

@GauravB159
Copy link
Contributor Author

Yes, I'll get on that today

@GauravB159
Copy link
Contributor Author

@aeschli I have added a few test cases for this.

Note: These might fail when considered with the code from #308 but I will correct them once either PR is merged so it should not be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GauravB159 @aeschli