Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: autocomplete for media queries #256

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jesperjen98
Copy link

Implementation of media query autocomplete for both media types and
features. The implementation is based on how the IProperyData interface
is implemented and may therefor contain a small amount of redundant
code. The modified files are: cssLanguageTypes.ts, webCustomData.ts,
dataManager.ts, dataprovider.ts, entry.ts, cssCompletion.ts.

Implementation of media query autocomplete for both media types and
features. The implementation is based on how the IProperyData interface
is implemented and may therefor contain a small amount of redundant
code. The modified files are: cssLanguageTypes.ts, webCustomData.ts,
dataManager.ts, dataprovider.ts, entry.ts, cssCompletion.ts.
@ghost
Copy link

ghost commented Dec 6, 2021

CLA assistant check
All CLA requirements met.

@aeschli
Copy link
Contributor

aeschli commented Dec 7, 2021

Cool thanks! You are extending the css custom data format and we should also update the related resources:

@jesperjen98
Copy link
Author

jesperjen98 commented Dec 16, 2021 via email

@soredake
Copy link

@jesperjen98 any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants