Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[highway] Bump to 1.2.0 #39086

Merged
merged 6 commits into from
Jun 26, 2024
Merged

[highway] Bump to 1.2.0 #39086

merged 6 commits into from
Jun 26, 2024

Conversation

xiaozhuai
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@xiaozhuai
Copy link
Contributor Author

xiaozhuai commented Jun 2, 2024

The CI failed on libjxl port which depends on highway.
I took a look at the libjxl port and found that things were a mess and the libjxl port needed to be refactored.

@xiaozhuai xiaozhuai marked this pull request as draft June 3, 2024 03:57
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Jun 3, 2024
@xiaozhuai xiaozhuai marked this pull request as ready for review June 24, 2024 05:16
@xiaozhuai
Copy link
Contributor Author

Hello @LilyWangLL
The libjxl port has been fixed. This pr is ready for review now.

@LilyWangLL
Copy link
Contributor

The new version of highway[contrib] build failed with the following error, could you please fix this error?

C:\PROGRA~1\MICROS~3\2022\ENTERP~1\VC\Tools\MSVC\1440~1.338\bin\Hostx64\x64\cl.exe   /TP -DHWY_SHARED_DEFINE -DTOOLCHAIN_MISS_ASM_HWCAP_H -DTOOLCHAIN_MISS_SYS_AUXV_H -Dhwy_contrib_EXPORTS -IF:\PRreview\vcpkg\buildtrees\highway\src\1.2.0-6e50e13274.clean /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  -std:c++17 /bigobj /W4 /wd4100 /wd4127 /wd4324 /wd4456 /wd4701 /wd4702 /wd4723 /GR- /EHs-c- -D_HAS_EXCEPTIONS=0 /showIncludes /FoCMakeFiles\hwy_contrib.dir\hwy\contrib\thread_pool\topology.cc.obj /FdCMakeFiles\hwy_contrib.dir\ /FS -c F:\PRreview\vcpkg\buildtrees\highway\src\1.2.0-6e50e13274.clean\hwy\contrib\thread_pool\topology.cc
cl : Command line warning D9025 : overriding '/W3' with '/W4'
cl : Command line warning D9025 : overriding '/GR' with '/GR-'
cl : Command line warning D9025 : overriding '/EHs' with '/EHs-'
cl : Command line warning D9025 : overriding '/EHc' with '/EHc-'
F:\PRreview\vcpkg\buildtrees\highway\src\1.2.0-6e50e13274.clean\hwy\contrib\thread_pool\topology.cc(67): error C2491: 'hwy::HaveThreadingSupport': definition of dllimport function not allowed
F:\PRreview\vcpkg\buildtrees\highway\src\1.2.0-6e50e13274.clean\hwy\contrib\thread_pool\topology.cc(75): error C2491: 'hwy::TotalLogicalProcessors': definition of dllimport function not allowed
F:\PRreview\vcpkg\buildtrees\highway\src\1.2.0-6e50e13274.clean\hwy\contrib\thread_pool\topology.cc(114): error C2491: 'hwy::GetThreadAffinity': definition of dllimport function not allowed
F:\PRreview\vcpkg\buildtrees\highway\src\1.2.0-6e50e13274.clean\hwy\contrib\thread_pool\topology.cc(176): error C2491: 'hwy::SetThreadAffinity': definition of dllimport function not allowed
F:\PRreview\vcpkg\buildtrees\highway\src\1.2.0-6e50e13274.clean\hwy\contrib\thread_pool\topology.cc(388): error C2491: 'hwy::Topology::Topology': definition of dllimport function not allowed

@LilyWangLL LilyWangLL marked this pull request as draft June 24, 2024 08:51
@xiaozhuai
Copy link
Contributor Author

The new version of highway[contrib] build failed with the following error, could you please fix this error?

@LilyWangLL OK, I'll look into it.

@xiaozhuai
Copy link
Contributor Author

xiaozhuai commented Jun 24, 2024

@LilyWangLL
Please review this again. The compile error has been solved by google/highway#2229, but it's not included in version 1.2.0. We need a patch here.

@xiaozhuai xiaozhuai marked this pull request as ready for review June 24, 2024 10:12
@LilyWangLL
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

Usage test passed on x64-windows.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 25, 2024
@BillyONeal BillyONeal merged commit 2f7e9e1 into microsoft:master Jun 26, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

@xiaozhuai xiaozhuai deleted the dev-highway branch June 27, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants