Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-client-java, default flavor=azure, if package is typespec-java #5384

Conversation

weidongxu-microsoft
Copy link
Contributor

@weidongxu-microsoft weidongxu-microsoft commented Dec 17, 2024

link #5380

  • default flavor depends on package
  • remove a (deprecated) emitter options
  • enable reportDiagnostics from TCGC diagnostics (we may get one error on https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/ai/azure-ai-inference, I guess we can ignore that package for now)
  • allow emitter runs on tsp without service -- this likely won't produce anything expected though (I've run it on tsp with only models, TCGC did not give me any model, even when I set access=public on them)

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label Dec 17, 2024
@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@weidongxu-microsoft weidongxu-microsoft force-pushed the http-client-java_default-flavor branch 2 times, most recently from d6802f0 to ef6a2c1 Compare December 17, 2024 03:41
@weidongxu-microsoft weidongxu-microsoft force-pushed the http-client-java_default-flavor branch from ef6a2c1 to 97a9afe Compare December 17, 2024 03:48
@weidongxu-microsoft weidongxu-microsoft added this pull request to the merge queue Dec 17, 2024
Merged via the queue into microsoft:main with commit ff550fa Dec 17, 2024
25 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the http-client-java_default-flavor branch December 17, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:java Issue for the Java client emitter: @typespec/http-client-java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants