Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cadl-ranch specs to http-specs and azure-http-specs #5357

Merged
merged 11 commits into from
Dec 18, 2024

Conversation

pshao25
Copy link
Contributor

@pshao25 pshao25 commented Dec 12, 2024

This is the non-azure part of Azure/azure-sdk-for-net#47325

We split previous cadl-ranch tests into two parts: pure Typespec: http-specs, and Azure Typespec: azure-http-specs.

This PR is to remove the old cadl-ranch and enable the tests from these two new ones. Then generate coverage report for both but just upload the unbranded one to dashboard.

The coverage can be successfully uploaded in this test build. https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4408920&view=results

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Dec 12, 2024
Pan Shao added 2 commits December 13, 2024 13:53
 Please enter the commit message for your changes. Lines starting
@pshao25 pshao25 marked this pull request as ready for review December 13, 2024 06:49
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Contributor

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that this PR is addressing? If not, can you please file one that explains what problem we need to solve?

@pshao25
Copy link
Contributor Author

pshao25 commented Dec 17, 2024

Is there an issue that this PR is addressing? If not, can you please file one that explains what problem we need to solve?

Yes, I added in the description.

@pshao25 pshao25 added this pull request to the merge queue Dec 18, 2024
Merged via the queue into microsoft:main with commit 7dc64d8 Dec 18, 2024
43 checks passed
@pshao25 pshao25 deleted the cadlranch47325 branch December 18, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants