Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt http/special-headers/conditional-request from cadl ranch #5318

Merged

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Dec 10, 2024

Fixes #3990

cherry picked from @nisha-bhatia 's PR for clarity.

But this requires the update in that PR to work properly.

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Dec 10, 2024
@ArcturusZhang ArcturusZhang force-pushed the cadl-ranch-conditional-request branch from 9c01626 to a13ba27 Compare December 10, 2024 07:18
@ArcturusZhang ArcturusZhang marked this pull request as ready for review December 10, 2024 07:18
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Contributor

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some merge conflicts.

@markcowl markcowl changed the title Adopt http/special-headers/conditional-request from cadl ranch [ DO NOT MERGE]: Adopt http/special-headers/conditional-request from cadl ranch Dec 10, 2024
@markcowl markcowl changed the title [ DO NOT MERGE]: Adopt http/special-headers/conditional-request from cadl ranch Adopt http/special-headers/conditional-request from cadl ranch Dec 11, 2024
@ArcturusZhang ArcturusZhang added this pull request to the merge queue Dec 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 16, 2024
@ArcturusZhang ArcturusZhang added this pull request to the merge queue Dec 16, 2024
Merged via the queue into microsoft:main with commit 9bc1675 Dec 16, 2024
21 checks passed
@ArcturusZhang ArcturusZhang deleted the cadl-ranch-conditional-request branch December 16, 2024 08:57
archerzz pushed a commit to archerzz/typespec that referenced this pull request Dec 17, 2024
…soft#5318)

Fixes microsoft#3990

cherry picked from @nisha-bhatia 's
[PR](microsoft#5214) for clarity.

But this requires the update in that PR to work properly.

---------

Co-authored-by: nisha-bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt http\special-headers\conditional-request from cadl ranch
4 participants