-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] support multi namespace #5271
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:python
Issue for the Python client emitter: @typespec/http-client-python
label
Dec 5, 2024
No changes needing a change description found. |
You can try these changes here
|
msyyc
changed the title
[Python] support multi namespace (not ready to review)
[Python] support multi namespace
Dec 11, 2024
msyyc
commented
Dec 11, 2024
@@ -0,0 +1,31 @@ | |||
# ------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already pass the test case for multinamespaces locally. However Azure/typespec-azure#1929 is not merged, so I have to annotate the test case.
…hon-multi-namespace
…hon-multi-namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Azure/autorest.python#2795.
Compared to the previous logic that only supported a single namespace, this PR introduces support for multiple namespaces. This primarily requires updates in two key areas:
imports
function.Considering these two main changes, here's a detailed summary of the updates in this PR:
enable-typespec-namespace
, which lets users decide if they want to support native typespec namespace.clientNamespace
for models/operations/enums/namedUnions/clients: the emitter usesclientNamespace
to determine the exact location where the target type should be.get_relative_import_path
for CodeModel: all relative import paths should be calculated using this function.client_namespace_types
to CodeModel: it counts and stores all namespace types and information aboutclients/operation_groups/enums/models
in each namespace.client_namespace_types
property in CodeModel, we can cycle through each namespace and serialize its clients/models/enums/operations using the same logic.relative_path
andoperation
kwargs, which were not set from the top caller but from various functions during the calling process. The signatures were difficult to understand and maintain. I replaces them with the newserialize_namespace
andserialize_namespace_type
kwargs. Now, any function that needs to calculate relative imports can use these two parameters, which are set from the top caller, making them easier to understand and maintain.