introduce the abstraction for tokencredential type and keycredential type #5231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
ArcturusZhang
commented
Nov 29, 2024
...csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Primitives/ScmKnownParameters.cs
Show resolved
Hide resolved
ArcturusZhang
commented
Dec 3, 2024
...ient-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/ClientProvider.cs
Show resolved
Hide resolved
ArcturusZhang
commented
Dec 3, 2024
...-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/RestClientProvider.cs
Show resolved
Hide resolved
ArcturusZhang
commented
Dec 3, 2024
...ient-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/ClientProvider.cs
Show resolved
Hide resolved
ArcturusZhang
force-pushed
the
abstraction-for-credentials
branch
from
2136cec to
cf3a23e
Compare
ArcturusZhang
commented
Dec 4, 2024
...generator/Microsoft.Generator.CSharp.ClientModel/test/OutputTypes/ScmKnownParametersTests.cs
Show resolved
Hide resolved
...ient-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/ClientProvider.cs
Show resolved
Hide resolved
...ient-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/ClientProvider.cs
Outdated
Show resolved
Hide resolved
...ient-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/ClientProvider.cs
Outdated
Show resolved
Hide resolved
...soft.Generator.CSharp.ClientModel/test/Providers/ClientProviders/ClientProviderTestsUtils.cs
Outdated
Show resolved
Hide resolved
...Microsoft.Generator.CSharp.ClientModel/test/Providers/ClientProviders/ClientProviderTests.cs
Show resolved
Hide resolved
...arp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/ClientPipelineProvider.cs
Outdated
Show resolved
Hide resolved
jorgerangel-msft
approved these changes
Dec 9, 2024
JoshLove-msft
approved these changes
Dec 10, 2024
...ient-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/ClientProvider.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Dec 13, 2024
archerzz
pushed a commit
to archerzz/typespec
that referenced
this pull request
Dec 17, 2024
…type (microsoft#5231) Fixes microsoft#5235 Fixes microsoft#4410 The ClientProviderTests class contains both general client provider features (such as service operations, query parameters, api-versions) and auth specific features. My PR is trying to separate them - therefore some test cases are moved to a new class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5235
Fixes #4410
The ClientProviderTests class contains both general client provider features (such as service operations, query parameters, api-versions) and auth specific features.
My PR is trying to separate them - therefore some test cases are moved to a new class.