docs: interface statement can have decorators #5202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncaq
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
ncaq
force-pushed
the
deviation-from-decorator-implementation
branch
from
9b3c531 to
4d96218
Compare
ncaq
added a commit
to ncaq/tree-sitter-typespec
that referenced
this pull request
Nov 28, 2024
Indeed, the web documentation makes it appear at first glance that interface does not have decorators, but looking at the implementation, it does. It is also shown in the example code. <https://github.com/microsoft/typespec/blob/a939c140980805dc66a9b6fef70be5647b1c9680/packages/samples/specs/versioning/main.tsp#L51> The PR to fix the standard and documentation has not yet been merged, but has already been submitted. [docs: interface statement can have decorators by ncaq · Pull Request #5202 · microsoft/typespec](microsoft/typespec#5202) I found it because of a problem that the parser here could not highlight the sample code correctly. I'll submit a PR here first as well.
ncaq
added a commit
to ncaq/tree-sitter-typespec
that referenced
this pull request
Nov 29, 2024
Indeed, the web documentation makes it appear at first glance that interface does not have decorators, but looking at the implementation, it does. It is also shown in the example code. <https://github.com/microsoft/typespec/blob/a939c140980805dc66a9b6fef70be5647b1c9680/packages/samples/specs/versioning/main.tsp#L51> The PR to fix the standard and documentation has not yet been merged, but has already been submitted. [docs: interface statement can have decorators by ncaq · Pull Request #5202 · microsoft/typespec](microsoft/typespec#5202) I found it because of a problem that the parser here could not highlight the sample code correctly. I'll submit a PR here first as well.
happenslol
pushed a commit
to happenslol/tree-sitter-typespec
that referenced
this pull request
Nov 29, 2024
* fix: Allow `interface_statement` to have `decorator_list` Indeed, the web documentation makes it appear at first glance that interface does not have decorators, but looking at the implementation, it does. It is also shown in the example code. <https://github.com/microsoft/typespec/blob/a939c140980805dc66a9b6fef70be5647b1c9680/packages/samples/specs/versioning/main.tsp#L51> The PR to fix the standard and documentation has not yet been merged, but has already been submitted. [docs: interface statement can have decorators by ncaq · Pull Request #5202 · microsoft/typespec](microsoft/typespec#5202) I found it because of a problem that the parser here could not highlight the sample code correctly.
microsoft-github-policy-service
bot
added
the
stale
|
Hi @ncaq. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
|
My PR living. |
Caused confusion for standards writers and others. Used list format because of the large amount of Examples.
The actual implementation was not reflected in the tree-sitter, so it was misunderstood when the tree-sitter was created.
ncaq
force-pushed
the
deviation-from-decorator-implementation
branch
from
4d96218 to
fb43fff
Compare
There was a problem hiding this comment.
I don't think we need to enumerate everything that can be decorated, since almost everything in TypeSpec can be decorated as long as it is a declaration of a Type. I recommended some slightly different language in my comments, but I'm happy to include interfaces specifically.
witemple-msft
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual implementation was not reflected in the tree-sitter, so it was misunderstood when the tree-sitter was created.