refactor(http-client-csharp): dump deprecated description properties
#5154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- emitter: replace all `description` properties of input types with `summary` and `doc` - generator: - update json converters for the emitter schema change - only expose `Summary` and `Doc` properties if they are used by other classes - update test cases accordingly part of microsoft#4771
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
archerzz
changed the title
filter-out-core-models optiondescription properties
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
....Generator.CSharp.ClientModel/test/Providers/ClientProviders/ClientProviderSubClientTests.cs
Outdated
Show resolved
Hide resolved
...ttp-client-csharp/generator/Microsoft.Generator.CSharp.Input/src/InputTypes/InputEnumType.cs
Outdated
Show resolved
Hide resolved
|
Changes since last review:
|
archerzz
requested review from
bterlson,
markcowl,
allenjzhang,
timotheeguerin,
iscai-msft,
tadelesh,
msyyc,
srnagar,
weidongxu-microsoft,
haolingdong-msft and
XiaofeiCao
as code owners
# Conflicts: # packages/compiler/src/server/serverlib.ts # packages/http-client-java/emitter/src/code-model-builder.ts # packages/http-client-java/emitter/src/emitter.ts # packages/http-client-java/generator/http-client-generator-test/package.json # packages/http-client-java/package-lock.json # packages/http-client-java/package.json # packages/typespec-vscode/src/code-action-provider.ts # packages/typespec-vscode/src/extension.ts # pnpm-lock.yaml
|
No changes needing a change description found. |
|
You can try these changes here
|
Fix Azure/autorest.python#2967 --------- Co-authored-by: Yuchao Yan <[email protected]>
The new pipeline https://dev.azure.com/azure-sdk/internal/_build?definitionId=7395&_a=summary has been given access to the storage account through security group. So, it is not required for any connection string to be in the yml file. This PR removes this string. Please review and approve this PR. Thanks
…5398) This PR adds the missing account name to the script. Please review and approve the PR. Thanks
…ft#5206) Fix microsoft#5155 When there is any changes/PR about typespec-vscode, we want to provide an extension to try. So we will publish `typespec-vscode-0.XXX.0.vsix` as pipeline artifact, and will show `VSCode Extension` with the download url in the try-it comment. Customer can download this extension file to try. --------- Co-authored-by: Mark Cowlishaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
descriptionproperties of input types withsummaryanddocSummaryandDocproperties if they are used by other classespart of #4771