updated and add a testing

microsoft · Dec 19, 2024 · f71eb30 · f71eb30
1 parent f87e06b
commit f71eb30
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 19 deletions.
diff --git a/packages/compiler/src/core/checker.ts b/packages/compiler/src/core/checker.ts
@@ -2929,27 +2929,27 @@ export function createChecker(program: Program, resolver: NameResolver): Checker
     } else if (identifier.parent && identifier.parent.kind === SyntaxKind.MemberExpression) {
       let base = resolver.getNodeLinks(identifier.parent.base).resolvedSymbol;
 
-      if (identifier.parent.selector === "::") {
-        if (base?.node === undefined && base?.declarations) {
-          // Process meta properties separately, such as `::parameters`, `::returnType`
-          for (const nodeModels of Object.values(base?.declarations)) {
-            if (nodeModels.kind === SyntaxKind.OperationStatement) {
-              const operation = nodeModels as OperationStatementNode;
-              addCompletion("parameters", operation.symbol);
-              addCompletion("returnType", operation.symbol);
-            }
-          }
-        } else if (base?.node?.kind === SyntaxKind.ModelProperty) {
-          // Process meta properties separately, such as `::type`
-          const metaProperty = base.node as ModelPropertyNode;
-          addCompletion("type", metaProperty.symbol);
+      if (base) {
+        if (base.flags & SymbolFlags.Alias) {
+          base = getAliasedSymbol(base, undefined);
         }
-      } else {
+
         if (base) {
-          if (base.flags & SymbolFlags.Alias) {
-            base = getAliasedSymbol(base, undefined);
-          }
-          if (base) {
+          if (identifier.parent.selector === "::") {
+            if (base?.node === undefined && base?.declarations && base.declarations.length > 0) {
+              // Process meta properties separately, such as `::parameters`, `::returnType`
+              const nodeModels = base?.declarations[0];
+              if (nodeModels.kind === SyntaxKind.OperationStatement) {
+                const operation = nodeModels as OperationStatementNode;
+                addCompletion("parameters", operation.symbol);
+                addCompletion("returnType", operation.symbol);
+              }
+            } else if (base?.node?.kind === SyntaxKind.ModelProperty) {
+              // Process meta properties separately, such as `::type`
+              const metaProperty = base.node as ModelPropertyNode;
+              addCompletion("type", metaProperty.symbol);
+            }
+          } else {
             addCompletions(base.exports ?? base.members);
           }
         }

diff --git a/packages/compiler/test/server/completion.test.ts b/packages/compiler/test/server/completion.test.ts
@@ -510,6 +510,36 @@ describe("identifiers", () => {
   });
 
   it("completes meta property '::parameters' and '::returnType' on operation", async () => {
+    const completions = await complete(
+      `
+      op base(one: string): void;    
+      @@doc(base::par┆, "Override");
+      `,
+    );
+
+    check(completions, [
+      {
+        label: "parameters",
+        insertText: "parameters",
+        kind: CompletionItemKind.Method,
+        documentation: {
+          kind: MarkupKind.Markdown,
+          value: "```typespec\nop base(one: string): void\n```",
+        },
+      },
+      {
+        label: "returnType",
+        insertText: "returnType",
+        kind: CompletionItemKind.Method,
+        documentation: {
+          kind: MarkupKind.Markdown,
+          value: "```typespec\nop base(one: string): void\n```",
+        },
+      },
+    ]);
+  });
+
+  it("completes meta property '::parameters' and '::returnType' using alias on operation", async () => {
     const completions = await complete(
       `
       op a(@doc("base doc") one: string): void;