Revert "Fix typeChangedFrom of template/union to catch invalid versio…

…ning" (#5247) Reverts #5191 This introduced a new bug when validating `@typeChangedFrom` references where the 'current' versioned type is a template or union. [Example](https://cadlplayground.z22.web.core.windows.net/prs/5191/?c=aW1wb3J0ICJAdHlwZXNwZWMvdmVyc2lvbmluZyI7DQoNCnVzaW5nIFbJFsUVQHNlcnZpY2UNCkDHMGVkKMckcykNCm5hbWVzcGFjZSBTYW1wbGUuVGV4dMU6ZW51bchOcyB7DQogIHYxLMUHMiwNCn3FXmFkZMtQLnYyKQ0KbW9kZWwgQmV0dGVyUmVzdWx0VHlwZcZCYsUWRm9vOiBzdHLmAKXFSsY10C9zaeQAlNkvQ3VzdG9txjXGMeUBHkNoYW5nZWRGcm9t7ACbLCBBcnJheTzKZT4pxDRmYWlsczrHHfAAtz7lAQzfWddZd29ya3M68QEK5gDE&e=%40typespec%2Fopenapi3&options=%7B%7D)
microsoft · Dec 3, 2024 · 968f9c9 · 968f9c9
1 parent ee359ef
commit 968f9c9
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 119 deletions.
diff --git a/.chronus/changes/fix-versioning-typechanged-2024-10-25-16-56-3.md b/.chronus/changes/fix-versioning-typechanged-2024-10-25-16-56-3.md
diff --git a/packages/versioning/src/validate.ts b/packages/versioning/src/validate.ts
@@ -226,18 +226,6 @@ function validateMultiTypeReference(program: Program, source: Type, options?: Ty
     const availMap = getAvailabilityMap(program, type);
     const availability = availMap?.get(version.name) ?? Availability.Available;
     if ([Availability.Added, Availability.Available].includes(availability)) {
-      // Check if there are any indexed/template arguments that are validated...
-      if (isTemplateInstance(type)) {
-        for (const arg of type.templateMapper.args) {
-          if (isType(arg)) {
-            validateReference(program, source, arg);
-          }
-        }
-      } else if (type.kind === "Union") {
-        for (const variant of type.variants.values()) {
-          validateReference(program, source, variant.type);
-        }
-      }
       continue;
     }
     reportDiagnostic(program, {

diff --git a/packages/versioning/test/incompatible-versioning.test.ts b/packages/versioning/test/incompatible-versioning.test.ts
@@ -387,106 +387,6 @@ describe("versioning: validate incompatible references", () => {
       });
     });
 
-    it("emit diagnostic when using @typeChangedFrom with a type parameter that does not yet exist in arrays", async () => {
-      const diagnostics = await runner.diagnose(`        
-        @test
-        @added(Versions.v2)
-        model Original {}
-
-        @test
-        @added(Versions.v2)
-        model Updated {}
-
-        @test
-        model Test {
-          @typeChangedFrom(Versions.v2, Original[])
-          prop: Updated;
-        }
-        `);
-      expectDiagnostics(diagnostics, {
-        code: "@typespec/versioning/incompatible-versioned-reference",
-        severity: "error",
-        message:
-          "'TestService.Test.prop' was added in version 'v1' but referencing type 'TestService.Original' added in version 'v2'.",
-      });
-    });
-
-    it("emit diagnostic when using @typeChangedFrom with a type parameter that does not yet exist in records", async () => {
-      const diagnostics = await runner.diagnose(`        
-        @test
-        @added(Versions.v2)
-        model Original {}
-
-        @test
-        @added(Versions.v2)
-        model Updated {}
-
-        @test
-        model Test {
-          @typeChangedFrom(Versions.v2, Record<Original>)
-          prop: Updated;
-        }
-        `);
-      expectDiagnostics(diagnostics, {
-        code: "@typespec/versioning/incompatible-versioned-reference",
-        severity: "error",
-        message:
-          "'TestService.Test.prop' was added in version 'v1' but referencing type 'TestService.Original' added in version 'v2'.",
-      });
-    });
-
-    it("emit diagnostic when using @typeChangedFrom with a type parameter that does not yet exist in unions", async () => {
-      const diagnostics = await runner.diagnose(`        
-        @test
-        @added(Versions.v2)
-        model Original {}
-
-        @test
-        @added(Versions.v2)
-        model Updated {}
-
-        @test
-        model Test {
-          @typeChangedFrom(Versions.v2, Original | string)
-          prop: Updated;
-        }
-        `);
-      expectDiagnostics(diagnostics, {
-        code: "@typespec/versioning/incompatible-versioned-reference",
-        severity: "error",
-        message:
-          "'TestService.Test.prop' was added in version 'v1' but referencing type 'TestService.Original' added in version 'v2'.",
-      });
-    });
-
-    it("emit diagnostic when using @typeChangedFrom with a type parameter that does not yet exist in template", async () => {
-      const diagnostics = await runner.diagnose(`        
-        @test
-        @added(Versions.v2)
-        model Original {}
-
-        @test
-        @added(Versions.v2)
-        model Updated {}
-
-        model Template<T> {
-          prop: T;
-        }
-
-        @test
-        model Test {
-          @typeChangedFrom(Versions.v2, Template<Original>)
-          prop: Updated;
-        }
-        `);
-      expectDiagnostics(diagnostics, {
-        code: "@typespec/versioning/incompatible-versioned-reference",
-        severity: "error",
-        message:
-          "'TestService.Test.prop' was added in version 'v1' but referencing type 'TestService.Original' added in version 'v2'.",
-      });
-    });
-
     it("succeed if version are compatible in model", async () => {
       const diagnostics = await runner.diagnose(`
         @added(Versions.v2)