Fix len for empty GeoDataset #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
|
I have no problem with 0.9.4! 0.9.0 was late 2019, anything earlier than that was 2016ish
|
calebrob6
approved these changes
Jan 28, 2022
adamjstewart
added a commit
that referenced
this pull request
Mar 19, 2022
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to compute the length of an empty GeoDataset, instead of returning 0, rtree crashes. See Toblerity/rtree#204 for a description of the issue. We can instead use
Index.get_size()which has a try-except that happens to catch this issue and return 0.Index.get_size()is undocumented and was added in rtree 0.9.4, which is relatively new. We could instead add our own try-except with the same implementation asIndex.get_size()if we want to support older versions of rtree. Thoughts on this?