update teamsjs sdk to 2.14.0 #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandin-borjigin
requested changes
Jun 13, 2023
src/index.js
Outdated
| @@ -55,6 +55,37 @@ function videoFrameHandler(videoFrame, notifyVideoProcessed, notifyError) { | |||
| // } | |||
| } | |||
|
|
|||
| async function videoStreamHandler(receivedVideoFrame) { | |||
There was a problem hiding this comment.
Remove leading white spaces.
nandin-borjigin
approved these changes
Jun 14, 2023
nandin-borjigin
requested changes
Jun 14, 2023
| @@ -55,6 +55,37 @@ function videoFrameHandler(videoFrame, notifyVideoProcessed, notifyError) { | |||
| // } | |||
| } | |||
|
|
|||
| async function videoStreamHandler(receivedVideoFrame) { | |||
There was a problem hiding this comment.
Since sample app serves as a public-facing example, we should write a handler that is dedicated for VideoFrame, rather than converting it to array buffer and falling back to T1 implementation.
There was a problem hiding this comment.
updated, created 2 filters that process VideoFrame instead of video array buffer, one shows how to process the video frame with WebGL, and the other one shows how to get video buffer from the VideoFrame and process it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.