Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - Fix stderr message in gpu-copy benchmark #673

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

dpower4
Copy link
Contributor

@dpower4 dpower4 commented Nov 27, 2024

Fix ordering of args in err messages.

@dpower4 dpower4 requested a review from a team as a code owner November 27, 2024 08:40
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.58%. Comparing base (96f5cce) to head (5c97c37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #673   +/-   ##
=======================================
  Coverage   85.58%   85.58%           
=======================================
  Files          98       98           
  Lines        7046     7046           
=======================================
  Hits         6030     6030           
  Misses       1016     1016           
Flag Coverage Δ
cpu-python3.10-unit-test 71.84% <ø> (ø)
cpu-python3.7-unit-test 71.81% <ø> (ø)
cpu-python3.8-unit-test 71.84% <ø> (ø)
cuda-unit-test 83.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@polarG polarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abuccts abuccts requested a review from yzygitzh November 28, 2024 00:25
@abuccts abuccts changed the title Fix: stderr output Bug Fix - Fix stderr message in gpu-copy benchmark Nov 28, 2024
@abuccts abuccts merged commit 4e6935a into microsoft:main Nov 28, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants