Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks: micro benchmarks - add nvbandwidth build #665

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Benchmarks: micro benchmarks - add nvbandwidth build #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3459eac
Init cpu copy.
Oct 30, 2024
4c9546c
Revert "Init cpu copy."
Oct 30, 2024
2a115dd
Merge branch 'microsoft:main' into main
polarG Nov 6, 2024
2778e37
Merge branch 'microsoft:main' into main
polarG Nov 11, 2024
63ffaba
Merge branch 'microsoft:main' into main
polarG Nov 15, 2024
820907b
Add nvbandwidth build.
Nov 16, 2024
3a51ad5
Fix required cmake version.
Nov 17, 2024
1f7c8e4
Remove cmake version verification.
Nov 20, 2024
cf84e5d
Exclude nvbandwidth with -o.
Nov 20, 2024
adc048d
Merge branch 'main' into microbenchmark/add_nvbandwidth_build
abuccts Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,6 @@
[submodule "third_party/Megatron/Megatron-DeepSpeed"]
path = third_party/Megatron/Megatron-DeepSpeed
url = https://github.com/microsoft/Megatron-DeepSpeed.git
[submodule "third_party/nvbandwidth"]
path = third_party/nvbandwidth
url = https://github.com/NVIDIA/nvbandwidth.git
2 changes: 1 addition & 1 deletion dockerfile/cuda11.1.1.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ ADD dockerfile/etc /opt/microsoft/
WORKDIR ${SB_HOME}

ADD third_party third_party
RUN make -C third_party cuda
RUN make -C third_party cuda -o nvbandwidth

ADD . .
RUN python3 -m pip install --upgrade setuptools==65.7 && \
Expand Down
9 changes: 7 additions & 2 deletions third_party/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ ROCM_VER ?= $(shell hipconfig -R | grep -oP '\d+\.\d+\.\d+' || echo "0.0.0")

NUM_MAKE_JOBS ?= $(shell nproc --ignore=2)

.PHONY: all cuda_with_msccl cuda rocm common cuda_cutlass cuda_bandwidthTest cuda_nccl_tests cuda_perftest cuda_msccl rocm_perftest fio rocm_rccl_tests rocm_rocblas rocm_bandwidthTest gpcnet cuda_gpuburn cpu_stream cpu_hpl directx_amf_encoding_latency directx_amd rocm_hipblaslt megatron_lm megatron_deepspeed apex_rocm
.PHONY: all cuda_with_msccl cuda rocm common cuda_cutlass cuda_bandwidthTest cuda_nccl_tests cuda_perftest cuda_msccl rocm_perftest fio rocm_rccl_tests rocm_rocblas rocm_bandwidthTest gpcnet cuda_gpuburn cpu_stream cpu_hpl directx_amf_encoding_latency directx_amd rocm_hipblaslt megatron_lm megatron_deepspeed apex_rocm nvbandwidth

# Build targets.
all: cuda rocm
cuda_with_msccl: cuda cuda_msccl
cuda: common cuda_cutlass cuda_bandwidthTest cuda_nccl_tests cuda_perftest gpcnet cuda_gpuburn megatron_lm megatron_deepspeed
cuda: common cuda_cutlass cuda_bandwidthTest cuda_nccl_tests cuda_perftest gpcnet cuda_gpuburn megatron_lm megatron_deepspeed nvbandwidth
rocm: common rocm_perftest rocm_rccl_tests rocm_rocblas rocm_bandwidthTest rocm_hipblaslt megatron_deepspeed apex_rocm
cpu: common cpu_perftest cpu_stream
common: fio
Expand Down Expand Up @@ -239,3 +239,8 @@ ifneq (,$(wildcard msccl/tests/msccl-tests-nccl/Makefile))
mkdir -p $(SB_MICRO_PATH)/bin/msccl-tests-nccl && \
cp -r -v ./msccl/tests/msccl-tests-nccl/build/* $(SB_MICRO_PATH)/bin/msccl-tests-nccl/
endif

# Build nvbandwidth.
nvbandwidth: sb_micro_path
cd ./nvbandwidth && cmake . && make && cd ..
cp -v ./nvbandwidth/nvbandwidth $(SB_MICRO_PATH)/bin
1 change: 1 addition & 0 deletions third_party/nvbandwidth
Open in desktop
Submodule nvbandwidth added at 445d8a
Loading