Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - Fix numa error on grace cpu in gpu-copy #658

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

dpower4
Copy link
Contributor

@dpower4 dpower4 commented Oct 30, 2024

The current GPU Copy BW Performance fails on Nvidia Grace systems. This is due to the memory only numa node and thus the numa_run_on_node fails for such nodes and halts completely.

This fix checks for the presence of assigned CPU cores for the numa node, on checking if it has no cpu cores assigned, it skips that specific node during the args creation and continues.

@dpower4 dpower4 requested a review from a team as a code owner October 30, 2024 21:35
@dpower4
Copy link
Contributor Author

dpower4 commented Oct 30, 2024

@dpower4 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree company="Microsoft"

@abuccts abuccts requested a review from yzygitzh October 30, 2024 22:25
@abuccts
Copy link
Member

abuccts commented Oct 31, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@yzygitzh
Copy link
Member

Thanks for the fix! I left one minor comment.

@yzygitzh
Copy link
Member

yzygitzh commented Oct 31, 2024

One major concern: with current fix, the dtoh/htod performance regarding to those non-CPU NUMA nodes are just skipped. We need to find a way to allocate memory buffers in non-CPU NUMA nodes (instead of current numa_run_on_node) and get these dtoh/htod tests done.

@dpower4

@dpower4
Copy link
Contributor Author

dpower4 commented Oct 31, 2024

One major concern: with current fix, the dtoh/htod performance regarding to those non-CPU NUMA nodes are just skipped. We need to find a way to allocate memory buffers in non-CPU NUMA nodes (instead of current numa_run_on_node) and get these dtoh/htod tests done.

@dpower4

Totally Agree. This case should only occur in case of single socket grace machines. will need a work around to handle the setting of node affinity for such nodes. Will work in it and create a separate PR.

@dpower4 dpower4 requested a review from yzygitzh October 31, 2024 03:20
Copy link
Contributor

@polarG polarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpower4 dpower4 force-pushed the fix/numa_error_grace branch from 87dc0ec to 41492d6 Compare November 4, 2024 16:24
@abuccts
Copy link
Member

abuccts commented Nov 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@abuccts abuccts changed the title Fix/numa error on grace Bug Fix - Fix numa error on grace cpu Nov 4, 2024
@abuccts abuccts changed the title Bug Fix - Fix numa error on grace cpu Bug Fix - Fix numa error on grace cpu in gpu-copy Nov 4, 2024
@abuccts abuccts added the bug Something isn't working label Nov 4, 2024
@abuccts abuccts enabled auto-merge (squash) November 4, 2024 22:31
@abuccts
Copy link
Member

abuccts commented Nov 5, 2024

/azp run ansible-integration-test

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

auto-merge was automatically disabled November 5, 2024 00:44

Head branch was pushed to by a user without write access

@dpower4 dpower4 requested a review from polarG November 5, 2024 00:53
Copy link
Contributor

@polarG polarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@abuccts
Copy link
Member

abuccts commented Nov 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@abuccts abuccts enabled auto-merge (squash) November 5, 2024 22:40
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (61770b8) to head (49db162).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files          97       97           
  Lines        6923     6923           
=======================================
  Hits         5940     5940           
  Misses        983      983           
Flag Coverage Δ
cpu-python3.6-unit-test 71.61% <ø> (ø)
cpu-python3.7-unit-test 71.61% <ø> (ø)
cpu-python3.8-unit-test 71.64% <ø> (ø)
cuda-unit-test 83.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abuccts abuccts merged commit 59d36f7 into microsoft:main Nov 5, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants