-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs - Fix metrics name in user tutorial #651
Docs - Fix metrics name in user tutorial #651
Conversation
Bumps [serve-static](https://github.com/expressjs/serve-static) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `serve-static` from 1.15.0 to 1.16.2 - [Release notes](https://github.com/expressjs/serve-static/releases) - [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md) - [Commits](expressjs/[email protected]) Updates `express` from 4.19.2 to 4.21.0 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/[email protected]) --- updated-dependencies: - dependency-name: serve-static dependency-type: indirect - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.11 #651 +/- ##
=============================================
Coverage 85.80% 85.80%
=============================================
Files 97 97
Lines 6923 6923
=============================================
Hits 5940 5940
Misses 983 983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…t-identical-usertutorial
@microsoft-github-policy-service agree company="Microsoft" |
**Description** In result-summary.md line 73-74, the example of kernel-launch used metrics 'kernel-launch/event_overhead' and 'kernel-launch/wall_overhead'. But in micro-benchmarks.md line 20-21, the metric names are described as 'kernel-launch/event_time' and ' kernel-launch/wall_time'. Solution: Use identical metric names described in micro-benchmarks.md. #649 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: hongtaozhang <[email protected]> Co-authored-by: Yifan Xiong <[email protected]>
**Description** Cherry pick bug fixes from v0.11.0 to main **Major Revision** * #645 * #648 * #646 * #647 * #651 * #652 * #650 --------- Co-authored-by: hongtaozhang <[email protected]> Co-authored-by: Yifan Xiong <[email protected]>
Description
In result-summary.md line 73-74, the example of kernel-launch used metrics 'kernel-launch/event_overhead' and 'kernel-launch/wall_overhead'.
But in micro-benchmarks.md line 20-21, the metric names are described as 'kernel-launch/event_time' and ' kernel-launch/wall_time'.
Solution: Use identical metric names described in micro-benchmarks.md.
#649
Major Revision
Minor Revision