Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Data Diagnosis - Fix bug of failure test and warning of pandas in data diagnosis #638

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

yukirora
Copy link
Contributor

Description
Fix bug of failure test and warning of pandas in data diagnosis.

Major Revision

  • fix warning of pandas in replace and fillna due to type downcast
  • fix bug of failure check function only check one matched metric rather than all matched metrics
  • fix bug when converting regex into str of metrics when there're more than one match group

@yukirora yukirora added bug Something isn't working tool labels Aug 13, 2024
@yukirora yukirora requested review from cp5555 and guoshzhao August 13, 2024 08:00
@yukirora yukirora requested a review from a team as a code owner August 13, 2024 08:00
@cp5555 cp5555 mentioned this pull request Aug 13, 2024
22 tasks
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (46a5792) to head (fb4b480).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #638   +/-   ##
=======================================
  Coverage   85.78%   85.78%           
=======================================
  Files          97       97           
  Lines        6921     6923    +2     
=======================================
+ Hits         5937     5939    +2     
  Misses        984      984           
Flag Coverage Δ
cpu-python3.6-unit-test 71.61% <100.00%> (+<0.01%) ⬆️
cpu-python3.7-unit-test 71.61% <100.00%> (+<0.01%) ⬆️
cpu-python3.8-unit-test 71.64% <100.00%> (+<0.01%) ⬆️
cuda-unit-test 83.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yukirora yukirora enabled auto-merge (squash) August 14, 2024 05:28
@yukirora yukirora disabled auto-merge August 15, 2024 03:01
@yukirora yukirora merged commit 7af75df into main Aug 16, 2024
19 of 22 checks passed
@yukirora yukirora deleted the yutji/data-diagnosis-fix branch August 16, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants