Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks: Add MSCCL Support for Nvidia GPU #584

Merged
merged 10 commits into from
Dec 7, 2023

Conversation

yzygitzh
Copy link
Member

@yzygitzh yzygitzh commented Dec 5, 2023

Description
Add MSCCL as basis of nccl-lat benchmark

@yzygitzh yzygitzh requested a review from a team as a code owner December 5, 2023 10:29
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd5a632) 85.98% compared to head (7dba07d) 85.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   85.98%   85.98%           
=======================================
  Files          97       97           
  Lines        6845     6845           
=======================================
  Hits         5886     5886           
  Misses        959      959           
Flag Coverage Δ
cpu-python3.6-unit-test 71.99% <ø> (ø)
cpu-python3.7-unit-test 71.99% <ø> (ø)
cpu-python3.8-unit-test 72.40% <ø> (ø)
cuda-unit-test 84.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cp5555 cp5555 requested review from yukirora and abuccts December 6, 2023 13:57
@cp5555 cp5555 added the benchmarks SuperBench Benchmarks label Dec 6, 2023
@cp5555 cp5555 changed the title Benchmarks: Microbenchmark - Add MSCCL as basis of nccl-lat benchmark Benchmarks: Add MSCCL Support for Nvidia GPU Dec 6, 2023
@cp5555 cp5555 mentioned this pull request Dec 6, 2023
30 tasks
@yzygitzh yzygitzh merged commit 6ef3a01 into microsoft:main Dec 7, 2023
23 checks passed
@yzygitzh yzygitzh deleted the ziyue/add-msccl branch December 7, 2023 11:57
@yukirora yukirora mentioned this pull request Dec 14, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks SuperBench Benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants