Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks: Micro benchmark - Add graph mode in NCCL/RCCL benchmarks for latency metrics #583

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Benchmarks: Micro benchmark - Add graph mode in NCCL/RCCL benchmarks for latency metrics #583

merged 4 commits into from
Dec 5, 2023

Conversation

yzygitzh
Copy link
Member

@yzygitzh yzygitzh commented Dec 4, 2023

Description
Revise NCCL/RCCL benchmarks to add latency metrics.

@yzygitzh yzygitzh requested a review from a team as a code owner December 4, 2023 14:01
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ae8c67) 86.36% compared to head (17af897) 86.36%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files          96       96           
  Lines        6572     6573    +1     
=======================================
+ Hits         5676     5677    +1     
  Misses        896      896
Flag Coverage Δ
cpu-python3.6-unit-test 71.78% <100.00%> (+<0.01%) ⬆️
cpu-python3.7-unit-test 71.78% <100.00%> (+<0.01%) ⬆️
cpu-python3.8-unit-test 72.22% <100.00%> (+<0.01%) ⬆️
cuda-unit-test 84.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yukirora
yukirora approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@yukirora yukirora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this title does not match the content?

@cp5555 cp5555 self-requested a review December 5, 2023 07:59
@cp5555 cp5555 added benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks labels Dec 5, 2023
@cp5555 cp5555 mentioned this pull request Dec 5, 2023
Closed
30 tasks
@yzygitzh yzygitzh changed the title Benchmarks: Micro benchmark - Add latency metrics for NCCL/RCCL benchmarks Benchmarks: Micro benchmark - Add graph mode in NCCL/RCCL benchmarks for latency metrics Dec 5, 2023
@yzygitzh yzygitzh merged commit 254ea7f into microsoft:main Dec 5, 2023
23 checks passed
@yzygitzh yzygitzh deleted the ziyue/add-nccl-graph branch December 5, 2023 08:48
@yukirora yukirora mentioned this pull request Dec 6, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukirora yukirora yukirora approved these changes

@cp5555 cp5555 cp5555 approved these changes

Assignees
No one assigned
Labels
benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yzygitzh @cp5555 @yukirora