Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks: micro benchmark - Support cpu-gpu and gpu-cpu in ib-validation #581

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

yukirora
Copy link
Contributor

Description
Benchmarks: micro benchmark - Support cpu-gpu and gpu-cpu in ib-validation

Major Revision

  • Support cpu-gpu and gpu-cpu in ib-validation

Minor Revision

  • support multi msg size, multi direction, multi ib commands in ib-validation

@yukirora yukirora requested a review from a team as a code owner November 29, 2023 13:26
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (028819b) 86.41% compared to head (aeb604f) 86.36%.

Files Patch % Lines
...arks/micro_benchmarks/ib_validation_performance.py 74.60% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   86.41%   86.36%   -0.05%     
==========================================
  Files          96       96              
  Lines        6544     6572      +28     
==========================================
+ Hits         5655     5676      +21     
- Misses        889      896       +7     
Flag Coverage Δ
cpu-python3.6-unit-test 71.78% <74.60%> (+0.01%) ⬆️
cpu-python3.7-unit-test 71.78% <74.60%> (+0.01%) ⬆️
cpu-python3.8-unit-test 72.21% <74.60%> (+0.01%) ⬆️
cuda-unit-test 84.30% <74.60%> (-0.04%) ⬇️
directx-unit-test 35.47% <6.34%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cp5555 cp5555 added benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks labels Nov 30, 2023
@cp5555 cp5555 mentioned this pull request Nov 30, 2023
30 tasks
@cp5555 cp5555 requested a review from guoshzhao November 30, 2023 05:49
@yukirora yukirora merged commit 9ae8c67 into main Dec 4, 2023
22 of 23 checks passed
@yukirora yukirora deleted the yutji/ib_validation_revision branch December 4, 2023 14:20
@yukirora yukirora mentioned this pull request Dec 6, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants