Analyzer - Generate baseline given results from multiple nodes. #573
Conversation
| @@ -0,0 +1,248 @@ | |||
| # Copyright (c) Microsoft Corporation. | |||
There was a problem hiding this comment.
Would you please add a document for this function?
| folder = args.input_dir | ||
| if args.algo == 'mean': | ||
| # simply use mean, need result_summary rules to define how to aggregate the metrics. | ||
| print('Generate baseine using mean of the data.') |
| logger.error('Analyzer: generate baseline failed, msg: {}'.format(str(e))) | ||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
Would you please remove the main()? It should be the feature for sb command
| @@ -0,0 +1,248 @@ | |||
| # Copyright (c) Microsoft Corporation. | |||
There was a problem hiding this comment.
Would you please add test for this function
| logger.error('Analyzer: generate statisitics failed, msg: {}'.format(str(e))) | ||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
Please remove the main as well. Shall we separate PR for these two functions? We can merge generate_baseline first.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 87.33% 79.65% -7.68%
==========================================
Files 89 95 +6
Lines 5946 7045 +1099
==========================================
+ Hits 5193 5612 +419
- Misses 753 1433 +680
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Input is jsonline file with results from multiple nodes, generate baseline file according to customized rules.