implement non-EXE support #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-wright
commented
Jun 10, 2024
| if !is_exe { | ||
| req.args | ||
| .splice(0..0, [req.application.clone()]); | ||
| req.application = get_default_application(&req.application).expect("Failed to get the default application"); |
There was a problem hiding this comment.
this might fail if a file doesn't have a file association with it. the standard behavior (non-sudo) is to open the open with prompt, so this might have to be changed before being merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds non-EXE support by running
ShellExecutewith the default application for files. I'm not familiar withAssocQueryStringW, so this should not be merged until someone who does know that function can look through it. invokingAssocQueryStringWtwice, first to getbuffer_sizeand then to fill the buffer, doesn't seem elegantI tested this on Windows 10 with sudo support. text files appeared to work, but any other file did not, likely due to some strange behavior with programs in locations with a space as defined in
shell/open/command. it may work on Windows 11, I have a machine I can test this on, but until that's fixed this shouldn't be merged