Improved the script

[HotCakeX]

• Changed the function name to PowerShell valid function name syntax.
• Added proper error types to the throw statements. It's best practice and also allows for catching specific errors later on when needed.
• Changed some variable types to full types instead of using type accelerators for better clarity.
• Removed all the unnecessary trailing whitespaces.
  • Used \s+$ in VS Code's search as regex.
• Changed double quotes to single quotes wherever possible for improved security, speed and to prevent string interpolation.

[HotCakeX]

@microsoft-github-policy-service agree

[lhecker]

Why not use [string], the builtin type?

[HotCakeX]

Because it eliminates confusion when we explicitly type out the fully qualified type name instead of using type accelerator/alias.

[lhecker]

I understand the other argument (in fact it's a fantastic one!), but this one seems to be just an opinion. (It's easily countered with "How does it eliminate confusion?", etc., for instance.) I'm not really meaning to press this further, however.

[HotCakeX]

The confusion elimination is by being explicit instead of implicit

like in this example

$CSharpCode = @'
namespace MyNamespace
{
    public class String
    {
        public string Value { get; set; }
    }
}
'@
Add-Type -TypeDefinition $CSharpCode
Set-Alias -Name String -Value MyNamespace.String
$myStringObject = [String]::new()
$myStringObject.Value = 'Hello'
$myStringObject.Value

That doesn't work unless i disambiguate it by using this

$myStringObject = [MyNamespace.String]::new()

since both System and my custom namespace have the same String class.