Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated REGEX to match full column reference only for Unqualified Column checks. #333

Closed
wants to merge 1 commit into from

Conversation

nebloc
Copy link

@nebloc nebloc commented Dec 5, 2024

Ran across an issue of a measure that includes the same word as a column triggering a failure for the unqualified columns check.

Example:

VAR Revenue =
    CALCULATE (
        SUMX (Opportunities, Opportunities[Value] ),
        FILTER (Opportunities, Opportunities[Status] = "Open" && VALUE(LEFT(Opportunities[Sales Stage Sort],1)) >=2))
RETURN
    Revenue + ( Revenue * ([Forecast Adjustment Value] / 100 ) )

Because Value is a column, the rule checks if it is prepended with Opportunities[. However, as it is also in the measure Forecast Adjustment Value it also triggers.

Believe updating the REGEX to force a match for the opening and closing square bracket should solve this.

@m-kovalsky
Copy link
Collaborator

Thanks. I believe this PR should solve this issue as well.

@m-kovalsky m-kovalsky closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants