used get function when accessing dictionaries. updated error message … #19
+522
−892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisber
requested changes
Jun 21, 2024
| new_data = { | ||
| "Object Name": pName, | ||
| "Parent Object Name": tName, | ||
| "Object Name": tName, |
There was a problem hiding this comment.
since you're repeating the column names for all types, I'd suggest to move them in variables/constants.
| "Annotation Name": caName, | ||
| "Annotation Value": caValue, | ||
| } | ||
| df = pd.concat( |
There was a problem hiding this comment.
I'd suggest to use this structure to make it more compact and readable (don't do the nested ifs, just iterate over the objects again):
rows = []
rows.extend([[t.Parent.Name, t.Name, "Calculation Group"] for t in tom.model.Tables])
rows.extend([
[t.Name, ci.Name, str(ci.ObjectType)]
for t in tom.model.Tables
if t.CalculationGroup is not None
for ci in t.CalculationGroup.CalculationItems
])
df = pd.DataFrame(rows, columns=["Parent Name", "Object Name", "Object Type"])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…handling.