-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Introducing vector search to the redis collections #9664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
python
Pull requests for the Python Semantic Kernel
memory
labels
Nov 12, 2024
eavanvalkenburg
force-pushed
the
redis_search
branch
from
November 12, 2024 14:22
ee68c94
to
c2c0f13
Compare
eavanvalkenburg
force-pushed
the
redis_search
branch
2 times, most recently
from
November 13, 2024 14:57
65adc9a
to
6f61f59
Compare
eavanvalkenburg
added
the
PR: breaking change
Pull requests that introduce breaking changes
label
Nov 13, 2024
TaoChenOSU
reviewed
Nov 13, 2024
python/semantic_kernel/connectors/memory/azure_ai_search/utils.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/azure_ai_search/utils.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/redis/redis_collection.py
Outdated
Show resolved
Hide resolved
eavanvalkenburg
force-pushed
the
redis_search
branch
from
November 14, 2024 09:26
4909005
to
0596755
Compare
moonbox3
approved these changes
Nov 14, 2024
TaoChenOSU
approved these changes
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Adds the vector search pieces to the two Redis collection types Features vectorized search and vector text search. Also features a slight change to the storage format for Hashsets since the existing was wrong because the index was not picking up those fields, fixed now, but if you have a Redis Hash Collection running, this will break things. Closes #6837 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 15, 2024
eavanvalkenburg
force-pushed
the
redis_search
branch
from
November 15, 2024 13:48
0596755
to
d99fc99
Compare
moonbox3
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
memory
PR: breaking change
Pull requests that introduce breaking changes
python
Pull requests for the Python Semantic Kernel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds the vector search pieces to the two Redis collection types
Features vectorized search and vector text search.
Also features a slight change to the storage format for Hashsets since the existing was wrong because the index was not picking up those fields, fixed now, but if you have a Redis Hash Collection running, this will break things.
Closes #6837
Description
Contribution Checklist