fix(healthcheck): Update Hubble Readiness & Liveliness probes #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deploy/hubble/manifests/controller/helm/retina/templates/agent/daemonset.yaml
Outdated
Show resolved
Hide resolved
matmerr
reviewed
Nov 20, 2024
| - hubble | ||
| - status | ||
| initialDelaySeconds: 30 | ||
| periodSeconds: 30 |
There was a problem hiding this comment.
How long does the hubble status cmd take to respond at scale? If the command is generally quick and fits within the 30s window, perfect, but if it's frequently greater than 30s for a healthy response then restarting the pod may do more harm than good
There was a problem hiding this comment.
Going to run some scale tests. TBC.
There was a problem hiding this comment.
The status should be pretty static w.r.t. scale. Should have the ring buffer size (which is fixed) as upper limit.
There was a problem hiding this comment.
Also some adjustments needed to run scale tests for hubble atm
|
Do any conditions exist with Hubble status where the exit code is 0 however the retina process itself is in a bad state? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating Readiness probe to use hubble status command
Adding a liveliness probe to use hubble status command
Related Issue
#1047
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Checks functioning as expected. Tested with an invalid tcp address to make the gRPC connection for hubble status and containers get recycled as expected.
Additional Notes