Pin datasets version in nlp-feature-extractors to resolve the huggingface-hub dependency conflict #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinuthakaranth
approved these changes
Feb 1, 2023
| raiutils>=0.3.0 |
There was a problem hiding this comment.
what's the update here in line 7? Is git tricking me here?!
gaugup
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to pin datasets>=2.9.0
https://pypi.org/project/datasets/#history
Description
We are seeing dependency vulnerability on responsible text image due to protobuf version pin in nlp-feature-extractors 0.0.3. And we want to upgrade nlp-feature-extractors to latest version, so that it doesn't have protobuf as dependency. But there is a dependency conflict for huggingface-hub where transformers requires huggingface-hub<1.0,>=0.11.0, and datasets in nlp-features-extractors requires huggingface-hub<0.1.0. Upgrading datasets to v2.9.0 can fix the dependency conflicts.
Checklist