Skip to content

Commit

Permalink
Fixes to the manual test suite (#5947)
Browse files Browse the repository at this point in the history
  • Loading branch information
debonte authored May 31, 2024
1 parent 6100ad4 commit f462e72
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
4 changes: 1 addition & 3 deletions testing/single/src/codeaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

# place cursor on `MyType` and confirm lightbulb shows up
# and trigger quick fix and confirm `Add 'from lib.userModule import MyType'` is listed
MyType
MyType()


# place cursor on `sys` and confirm lightbulb shows up
Expand Down Expand Up @@ -85,6 +85,4 @@ def function():
# place cursor on `event` and confirm lightbulb shows up
# and trigger quick fix and confirm `Create Type Stub` entry is listed
# execute the code action and confirm it works as expected
# Please note that currently it doesn't work. It's a known issue tracked at
# https://github.com/microsoft/pylance-release/issues/5188
import zope.event
7 changes: 4 additions & 3 deletions testing/single/src/notebook.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"\n",
"# place cursor on `MyType` and confirm lightbulb not shows up\n",
"# since it is imported from cell above\n",
"MyType\n",
"MyType()\n",
"\n",
"# place cursor on `sys` and confirm lightbulb shows up\n",
"# and trigger quick fix and confirm `remove unused import` is listed\n",
Expand Down Expand Up @@ -121,8 +121,6 @@
"# place cursor on `event` and confirm lightbulb shows up\n",
"# and trigger quick fix and confirm `Create Type Stub` entry is listed\n",
"# execute the code action and confirm it works as expected\n",
"# Please note that currently it doesn't work. It's a known issue tracked at\n",
"# https://github.com/microsoft/pylance-release/issues/5188\n",
"import zope.event"
]
},
Expand Down Expand Up @@ -194,6 +192,9 @@
"# also due to https://github.com/microsoft/vscode/issues/202293\n",
"from typing import Optional\n",
"\n",
"# This is currently broken. Document highlight acts like string search instead of\n",
"# semantic search -- https://github.com/microsoft/pylance-release/issues/5706\n",
"\n",
"# place cursor on `variable` and confirm all `variable` referenced in the document\n",
"# is highlighted\n",
"variable = \"Hello\"\n",
Expand Down

0 comments on commit f462e72

Please sign in to comment.