-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for network isolation and account key removal #309
Conversation
Unused, and flagging vulnerabilities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to merge this once CI passes.
Test failures hopefully fixed (azurite doesn't support token credentials, so we need to use the account key in |
New failure at https://github.com/microsoft/planetary-computer-tasks/actions/runs/9863208116/job/27235465737?pr=309#step:6:78.
I couldn't reproduce it. Updated the test to ignore the order... |
I don't know why the integration tests are failing (presumably auth?) but AFAICT there's nothing in the logs indicating what the issue is. I haven't been able to run the integration tests locally. I'm inclined to just skip them at this point :/ |
This reverts commit aadd0ac.
I think we'll need to revert some of the changes to the Helm chart removing the account key from the pctasks-server Deployment. IIUC these integration tests are using Azurite, which requires the account key. I'll try that quick. |
Wohoo, finally passing. |
Updates to the deployment and runtime to