Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TOML #4786

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement TOML #4786

wants to merge 1 commit into from

Conversation

Pistonight
Copy link

Issue

TOML is not supported

Fix

Support TOML

References taken from

Valiation

Unit tests added according to https://toml.io/en/v1.0.0. Most of the tests are taken directly from the examples in the spec, but some are tweaked to have more coverage.

Also tested in a testing app with vs-dark and light theme

vs-dark

monaco-toml-dark

vs

monaco-toml-light

Other

Closes #2798

This is my first monarch language. I didn't do benchmark on performance but it can probably be made faster. However I just made the states in the way it made sense in my head.

The sample file is taken from https://github.com/rust-lang/rust/blob/master/triagebot.toml, which covers a lot of the interesting cases

@Pistonight
Copy link
Author

@microsoft-github-policy-service agree

@Pistonight
Copy link
Author

@Pistonight please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOML language support
1 participant