Update webpack plugin to support module workers #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
2 tasks
|
Bump -- could really use this for my team |
michaelhabibi
approved these changes
Nov 15, 2024
|
*gentle nudge* Is there anything I can do to get eyes on this one? 🙏 |
|
good,Hopefully it will merge soon |
icholy
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #4741 .
This PR updates the
monaco-editor-webpack-plugin'sgetWorkerUrlto add support for module workers. The function now checks ifimport.metais defined, and if so, usesimportto load the worker script. Otherwise, it falls back to usingimportScriptsfor classic workers.