Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated vscode-json-languageservice to 5.3.9 #4354

Conversation

harrismirza
Copy link

Updated vscode-json-languageservice to the latest version, in order to fix the bug where validating JSON against the latest JSON Schema Drafts would not work correctly (microsoft/vscode-json-languageservice#122)

@harrismirza
Copy link
Author

@microsoft-github-policy-service agree

@harrismirza
Copy link
Author

harrismirza commented Mar 11, 2024

Just to add, this would also resolve issues #3625, #4114 and #3160

@hediet @aeschli Would you be able to review this?

@harrismirza harrismirza changed the title Updated vscode-json-languageservice to 5.3.7 Updated vscode-json-languageservice to 5.3.9 Mar 13, 2024
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 13, 2024
@daviesgeek
Copy link

Wondering if this will be included in the March release, am heavily invested in seeing support for 2020-12 schema support. Am willing to help out in any way I can.

@aeschli
Copy link
Contributor

aeschli commented Mar 28, 2024

@daviesgeek full 2020-12 schema support is still not implemented in vscode-json-languageservice. There's currently no resources to work on this on our side.

@harrismirza
Copy link
Author

Hey @aeschli, @deepak1556,

Is there a reason this wasn't included with the March release? I was looking forward to using this.

Even though this doesn't include full schema 2020-12 support, currently just having the schema property set to anything newer than draft-07 completely breaks validation.

@hediet hediet modified the milestones: April 2024, May 2024 Apr 25, 2024
@harrismirza
Copy link
Author

Hey, sorry to keep asking about this, but is there a particular reason this merge keeps being pushed?

@jrsquared
Copy link

Same question. I've been telling customers that it is coming, first in March, then April, and now May.

@daviesgeek
Copy link

Same here

@hediet
Copy link
Member

hediet commented May 3, 2024

Thanks for the PR and sorry for the delay! Just updated all of the langugae services.

@hediet hediet closed this May 3, 2024
@jrsquared
Copy link

Thank you!

@jrsquared
Copy link

Why didn't the update to languageservices make it in 0.49?

@harrismirza harrismirza deleted the feature/update-vscode-json-languageservice-to-5.3.7 branch May 26, 2024 00:07
@elisherer
Copy link

Seems like publishing is not done by CI/CD, so maybe someone forgot to update node modules before publishing... 🙄

@jrsquared
Copy link

@hediet Can we confirm that this will make it into the 0.50 release?

@elisherer
Copy link

Seems to be added to 0.50.0 (using 5.3.11)

But, I get the error

{
"$schema": "https://json-schema.org/draft/2019-09/schema",
// The schema uses meta-schema features ($recursiveRef) that are not yet supported by the validator
}

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.