-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated vscode-json-languageservice to 5.3.9 #4354
Updated vscode-json-languageservice to 5.3.9 #4354
Conversation
@microsoft-github-policy-service agree |
Wondering if this will be included in the March release, am heavily invested in seeing support for 2020-12 schema support. Am willing to help out in any way I can. |
@daviesgeek full 2020-12 schema support is still not implemented in vscode-json-languageservice. There's currently no resources to work on this on our side. |
Hey @aeschli, @deepak1556, Is there a reason this wasn't included with the March release? I was looking forward to using this. Even though this doesn't include full schema 2020-12 support, currently just having the schema property set to anything newer than draft-07 completely breaks validation. |
Hey, sorry to keep asking about this, but is there a particular reason this merge keeps being pushed? |
Same question. I've been telling customers that it is coming, first in March, then April, and now May. |
Same here |
Thanks for the PR and sorry for the delay! Just updated all of the langugae services. |
Thank you! |
Why didn't the update to languageservices make it in 0.49? |
Seems like publishing is not done by CI/CD, so maybe someone forgot to update node modules before publishing... 🙄 |
@hediet Can we confirm that this will make it into the 0.50 release? |
Seems to be added to 0.50.0 (using 5.3.11) But, I get the error {
"$schema": "https://json-schema.org/draft/2019-09/schema",
// The schema uses meta-schema features ($recursiveRef) that are not yet supported by the validator
} |
Updated vscode-json-languageservice to the latest version, in order to fix the bug where validating JSON against the latest JSON Schema Drafts would not work correctly (microsoft/vscode-json-languageservice#122)