Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript to TS 5.4.5 in all projects, vendored files #4305

Merged
merged 1 commit into from
May 3, 2024
Merged

Update TypeScript to TS 5.4.5 in all projects, vendored files #4305

merged 1 commit into from
May 3, 2024

Conversation

johnyanarella
Copy link
Contributor

This commit updates the version of TypeScript vendored into the monaco-editor (via npm run import-typescript) to the latest version (5.3.3). It also aligns the explicit TypeScript dependencies throughout the repo for "typescript" to match.

This upgrade is essential to ensure monaco-editor can provide accurate diagnostics for JSX when using the latest React types (ex. via addExtraLib()), given the introduction of JSX.ElementType and associated changes to TypeScript support for JSX introduced in TypeScript 5.1.

cc: @jakebailey (as this follows your example from #3721)

@johnyanarella
Copy link
Contributor Author

@microsoft-github-policy-service agree

@wirekang
Copy link

VSCode already supported TypeScript 5.3 few months ago. Why this PR is hanging so long?

@johnyanarella johnyanarella changed the title Update TypeScript to TS 5.3.3 in all projects, vendored files Update TypeScript to TS 5.4.2 in all projects, vendored files Mar 7, 2024
@johnyanarella
Copy link
Contributor Author

johnyanarella commented Mar 7, 2024

Updated to upgrade to TypeScript v5.4.2 now.

Recapping - the changes introduced by this PR were:

  • bumping the version of TypeScript in all of the package.json files (and tsdocs for the website to be compatible)
  • running npm i and yarn install (for the website) for the affected packages
  • executing the pre-existing import-typescript script from the root package.json to generate the vendored files

I completely understand if it is awkward to accept the PR given the large amount of generated / vendor code. Perhaps a maintainer could pull this PR locally and then re-run the import-typescript script to validate that the PR contains the unmodified outcome of the script your team created (i.e. no changes to commit).

@johnyanarella johnyanarella changed the title Update TypeScript to TS 5.4.2 in all projects, vendored files Update TypeScript to TS 5.4.3 in all projects, vendored files Apr 2, 2024
@johnyanarella
Copy link
Contributor Author

@hediet Noticed your recent bumps to other dependencies. Can you help with this? (see also #4412)

@jakebailey
Copy link
Member

FWIW you probably want to wait for 5.4.4, just because it has some critical bugfixes.

@johnyanarella
Copy link
Contributor Author

Great to know. Thanks, @jakebailey!

@johnyanarella johnyanarella changed the title Update TypeScript to TS 5.4.3 in all projects, vendored files Update TypeScript to TS 5.4.4 in all projects, vendored files Apr 6, 2024
@johnyanarella
Copy link
Contributor Author

Updated to upgrade to TypeScript v5.4.4 now.

@jakebailey
Copy link
Member

Looks like we're getting a 5.4.5 too, sorry!

@johnyanarella johnyanarella changed the title Update TypeScript to TS 5.4.4 in all projects, vendored files Update TypeScript to TS 5.4.5 in all projects, vendored files Apr 12, 2024
@johnyanarella
Copy link
Contributor Author

Updated PR to upgrade to TypeScript v5.4.5 now.

@IMax153
Copy link

IMax153 commented Apr 26, 2024

Is there any progress on this PR? Will we have access to the updated TS version at some point soon?

@hediet hediet enabled auto-merge May 3, 2024 09:41
@hediet hediet added this to the May 2024 milestone May 3, 2024
@hediet
Copy link
Member

hediet commented May 3, 2024

Thanks! Sorry for the delay!

@IMax153
Copy link

IMax153 commented May 3, 2024

@hediet - apologies for the ping, but does this need approval from another maintainer?

It looks like CI is locked up on Community PR Approvals.

@hediet hediet merged commit b400f83 into microsoft:main May 3, 2024
3 checks passed
@alexr00
Copy link
Member

alexr00 commented May 3, 2024

Delay was on me. I was reviewing and noticed an issue while doing so, and then I used this PR to investigate the issue I was seeing.

@IMax153
Copy link

IMax153 commented May 3, 2024

Delay was on me. I was reviewing and noticed an issue while doing so, and then I used this PR to investigate the issue I was seeing.

Thank you both so much for getting this PR over the finish line :)

@hax
Copy link

hax commented May 8, 2024

We use this PR several months, glad to see it finally be merged, hope the new version will be released soon so we can switch back to the official release. Thank you!

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants