-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TypeScript to TS 5.4.5 in all projects, vendored files #4305
Conversation
@microsoft-github-policy-service agree |
VSCode already supported TypeScript 5.3 few months ago. Why this PR is hanging so long? |
Updated to upgrade to TypeScript v5.4.2 now. Recapping - the changes introduced by this PR were:
I completely understand if it is awkward to accept the PR given the large amount of generated / vendor code. Perhaps a maintainer could pull this PR locally and then re-run the import-typescript script to validate that the PR contains the unmodified outcome of the script your team created (i.e. no changes to commit). |
FWIW you probably want to wait for 5.4.4, just because it has some critical bugfixes. |
Great to know. Thanks, @jakebailey! |
Updated to upgrade to TypeScript v5.4.4 now. |
Looks like we're getting a 5.4.5 too, sorry! |
Updated PR to upgrade to TypeScript v5.4.5 now. |
Is there any progress on this PR? Will we have access to the updated TS version at some point soon? |
Co-authored-by: John Yanarella <[email protected]>
Thanks! Sorry for the delay! |
@hediet - apologies for the ping, but does this need approval from another maintainer? It looks like CI is locked up on |
Delay was on me. I was reviewing and noticed an issue while doing so, and then I used this PR to investigate the issue I was seeing. |
Thank you both so much for getting this PR over the finish line :) |
We use this PR several months, glad to see it finally be merged, hope the new version will be released soon so we can switch back to the official release. Thank you! |
This commit updates the version of TypeScript vendored into the monaco-editor (via
npm run import-typescript
) to the latest version (5.3.3). It also aligns the explicit TypeScript dependencies throughout the repo for "typescript" to match.This upgrade is essential to ensure monaco-editor can provide accurate diagnostics for JSX when using the latest React types (ex. via
addExtraLib()
), given the introduction of JSX.ElementType and associated changes to TypeScript support for JSX introduced in TypeScript 5.1.cc: @jakebailey (as this follows your example from #3721)