Add zip handling #22
Merged
Add zip handling #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
gagb
reviewed
Dec 14, 2024
gagb
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for converting ZIP files to markdown by extracting and converting all contained files. The most important changes include updating the documentation, importing necessary modules, implementing the
ZipConverterclass, registering the new converter, and adding tests for ZIP file processing. This uses the same logic that we use for handling zip files in AGiXT and is very useful.ZIP file conversion support:
README.md: Updated to include ZIP file support in the list of supported formats.src/markitdown/_markitdown.py: Imported thezipfilemodule to handle ZIP file operations.Implementation of
ZipConverter:src/markitdown/_markitdown.py: Added theZipConverterclass to handle the extraction and conversion of ZIP file contents.src/markitdown/_markitdown.py: Registered theZipConverterin the__init__method to enable its use in the conversion process.src/markitdown/_markitdown.py: Updated the_convertmethod to include the list of converters for nested processing.Testing:
tests/test_markitdown.py: Added tests to verify the correct processing of ZIP files and their contents.