Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for OneHotEncoder in newer SKL versions #696

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ksaur
Copy link
Contributor

@ksaur ksaur commented Apr 4, 2023

Working on #684
Prototype for ints works, simple strings work

todo: Some problem with the user issue example.
todo: More impl/testing for strings.

in progress

@ksaur ksaur linked an issue Apr 4, 2023 that may be closed by this pull request
@ksaur ksaur force-pushed the ksaur/one-hot-handle-unknown-684 branch from 866422a to 6f18e25 Compare April 5, 2023 04:16
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #696 (afff99a) into main (ea84cc5) will increase coverage by 0.01%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   90.14%   90.15%   +0.01%     
==========================================
  Files          80       80              
  Lines        4625     4674      +49     
  Branches      848      864      +16     
==========================================
+ Hits         4169     4214      +45     
- Misses        259      261       +2     
- Partials      197      199       +2     
Flag Coverage Δ
unittests 90.15% <92.85%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tor_converters/_one_hot_encoder_implementations.py 93.93% <92.15%> (-2.29%) ⬇️
.../ml/operator_converters/sklearn/one_hot_encoder.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ksaur ksaur marked this pull request as ready for review April 21, 2023 17:19
@ksaur ksaur requested a review from interesaaat April 21, 2023 17:19
@ksaur ksaur marked this pull request as draft April 21, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sklearn] OneHotEncoder does't work correctly
2 participants