Skip to content

Commit

Permalink
Remove unused cols from final entities (#1226)
Browse files Browse the repository at this point in the history
* Remove unused cols from final entities

* Move verbs test to integ

* Move verbs test to integ

* Move to smoke tests
  • Loading branch information
AlonsoGuevara authored Sep 27, 2024
1 parent 737a471 commit 0d348d6
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/python-smoke-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ jobs:
run: |
poetry build
- name: Verb Test
run: |
poetry run poe test_verbs
- name: Install Azurite
id: azuright
uses: potatoqualitee/[email protected]
Expand Down
4 changes: 4 additions & 0 deletions .semversioner/next-release/patch-20240927171840021536.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "patch",
"description": "Remove unused column from final entities"
}
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ async def create_final_entities(
# Drop rows with NaN 'description_embedding' if not using vector store
if not description_text_embed.get("strategy", {}).get("vector_store"):
nodes = nodes.loc[nodes["description_embedding"].notna()]
nodes.drop(columns="name_description", inplace=True)

# Return final result
return create_verb_result(cast(Table, nodes))

0 comments on commit 0d348d6

Please sign in to comment.