Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Virtualizer): update examples for better accessibility and add a11y docs section #33537

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smhigley
Copy link
Contributor

Couple docs-only updates to virtualizer stories that add:

  • explicit tabindex + aria-label to examples to allow keyboard scrolling & avoid having all content get read out when the scroll area is focused (some but not all browsers, e.g. Edge and Firefox, already make scroll overflow regions tabbable by default).
  • add aria-live to the scroll-to example's text for screen reader feedback on scroll
  • add a small a11y docs section to explain the tabindex & when it is or isn't needed

I only added these to the scroll & dynamic scroll components since the base virtualizer doesn't have the container node built in, but I was kinda iffy on whether the base virtualizer should have it too.

Related Issue(s)

@smhigley smhigley requested review from Mitch-At-Work and a team as code owners December 31, 2024 20:30
Copy link

📊 Bundle size report

✅ No changes found

Copy link

Pull request demo site: URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant