Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix borderBottomRightRadius value casting error #31013

Closed

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 10, 2024

Note

This is being merged into the xplat branch, not master

Previous Behavior

Android app crashes when trying to render <Button shape="square">

New Behavior

Android app no longer crashes when trying to render <Button shape="square">

Screenshot_1712740607

@tido64 tido64 requested review from a team as code owners April 10, 2024 09:23
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff Tommy, was able to repro locally that indeed your fix works!

The changes LGTM

@tido64
Copy link
Member Author

tido64 commented Apr 15, 2024

@behowell: Before we merge this, could you have a look and see if the change makes sense? I'm not sure if this should be addressed here in FluentUI, in RSD, or in RN.

@behowell
Copy link
Contributor

Hmm, I don't think we should be modifying tokens in the xplat branch. It seems like ideally this would be fixed in RSD. Alternatively, it could be fixed in the griffel stylex adapter, to automatically convert '0' to 0.

@tido64
Copy link
Member Author

tido64 commented Apr 16, 2024

Closing; I'm going to attempt a fix in RSD.

PR: facebook/react-strict-dom#91

@tido64 tido64 closed this Apr 16, 2024
@tido64 tido64 deleted the tido/fix-borderBottomRightRadius-redbox branch April 16, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants