Serverless fix #52
Open
Serverless fix #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidhishanair
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
The changes lgtm, maybe we want to add these param passing to model tests to catch these early next time :) @safooray thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LlamaServerlessAzureRestEndpointModel
Updates the type of Llama specific parameters that were previously declared as str to bool. Previously, the api would ignore the parameters set as str.
MistralServerlessAzureRestEndpointModel
Similar as above for the safe_prompt parameter
ServerlessAzureRestEndpointModel
Similar as above for the stream parameter
Also adds "extra-parameters": "pass-through" to keep the class compatible with Llama 3.2