Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix #49

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Hotfix #49

merged 6 commits into from
Nov 15, 2024

Conversation

safooray
Copy link
Collaborator

  • added an argument to inference component to accommodate adding columns to resume from component.
  • improved the check for column mismatch in resume_from
  • removed token counting from promp_processing component for speed up

@safooray safooray requested a review from lalo November 14, 2024 23:25
@safooray safooray linked an issue Nov 14, 2024 that may be closed by this pull request
bugs due to rewriting column names of HF datasets #50
Closed
@safooray safooray requested a review from lalo November 15, 2024 21:20
vidhishanair
vidhishanair approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@vidhishanair vidhishanair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@safooray safooray merged commit 1713e79 into main Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidhishanair vidhishanair vidhishanair approved these changes

@lalo lalo Awaiting requested review from lalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bugs due to rewriting column names of HF datasets
3 participants
@safooray @lalo @vidhishanair