Speedup LRU by using the faster timestamp API #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
dthaler
reviewed
Nov 9, 2024
Alan-Jowett
force-pushed
the
speedup_lru
branch
4 times, most recently
from
579ec86
to
6f64fe9
Compare
dthaler
reviewed
Nov 12, 2024
Alan-Jowett
force-pushed
the
speedup_lru
branch
from
6f64fe9
to
ad8b3bf
Compare
saxena-anurag
previously approved these changes
Nov 12, 2024
mikeagun
previously approved these changes
Nov 12, 2024
added 3 commits
November 12, 2024 14:41
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
dismissed stale reviews from mikeagun and saxena-anurag
via
1294460
Alan-Jowett
force-pushed
the
speedup_lru
branch
from
a7f7c49
to
1294460
Compare
mikeagun
approved these changes
Nov 12, 2024
saxena-anurag
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to improve the performance and alignment of the LRU map implementation in the
ebpf_maps.cfile. The most important changes include adding a static assertion for cache alignment and switching the time query function to optimize performance.Performance improvements:
libs/execution_context/ebpf_maps.c: Replacedebpf_query_time_since_boot(false)withKeQueryInterruptTime()to optimize the time query operation in the_insert_into_hot_listfunction.Alignment improvements:
libs/execution_context/ebpf_maps.c: Added a static assertion to ensureebpf_lru_partition_tis cache aligned.Testing
CI/CD
Before:
After:
Documentation
No.
Installation
No.